Imagine creating a distro that supports two different types of sites: a blog style site and a news style site. Now imagine that you create a custom commenting module for this distro that is appropriate for both. Where should this module live? It can live in sites/all, but best practices say this should live in the profiles/my_profile/modules folder since you want the module to remain pristine and only be updated during a profile update. Right now, because there are two profile folders in my example, you need to have two copies of the custom commenting module or you need to create a shared folder somewhere and symlink to it.
Niether is ideal.
UPDATE: it turns out that if you use a symlink and put modules in some other location, that their simpletests will not run. This patch solves that issue as well...
Simply by adding one line to drupal_system_listing() function this can be accomplished.
Needs discussion, review, & documentation
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 1617860_d7-do-not-test.patch | 1.36 KB | bleen |
| profiles-all.patch | 1.71 KB | bleen |
Comments
Comment #1
bleen commentedThis is a D7 backport of the origin patch
Comment #2
attiks commentedIt's working for me, I assume there's no easy way to let testbot test this? If there is, maybe add a test to be sure.
Comment #3
bleen commentedre: #2 ... I couldn't think of a way.
I hope I'm not stretching it with a D7 backport, but I cant see the possible harm... and I really want a backport :)
Comment #4
attiks commented@bleen18, same here D7 would be awesome.
Comment #5
tstoecklerI don't think this should be committed as is, so marking back to "needs review".
I think we should go ahead with #562042: Search for install profiles in sites/[all|site]/profiles folders, and move core profiles into /core/profiles first. This issue should be updated in light of that.
We will have a sites/all/profiles folder, but I don't know how that works with profile-specific modules.
Comment #6
David_Rothstein commentedThis looks like a duplicate of #295434: Support contrib being placed in profiles/all, except that was already marked "won't fix" in favor of #562042: Search for install profiles in sites/[all|site]/profiles folders, and move core profiles into /core/profiles....
So yeah, this is a confusing set of issues :)
Comment #7
patcon commentedMight a base inheritable install profile be a possible alternative?
#1356276: Allow profiles to define a base/parent profile
Comment #8
bleen commentedRe #6: I think this is the identical solution proposed in #295434: Support contrib being placed in profiles/all but for a different reason.
Re #7: I think #1356276: Allow profiles to define a base/parent profile looks to be a solid alternative to the approach in this issue.
So.... given the other issues mentioned in 5, 6, & 7 I'm going to mark this as postponed to see if one of those issues (or a combination of them) ends up solving the problem outlined here.
Comment #9
tstoecklerYes postponed sounds great. I had not thought of the relation to #1356276: Allow profiles to define a base/parent profile, but with that and #562042: Search for install profiles in sites/[all|site]/profiles folders, and move core profiles into /core/profiles, I tend to think this is a duplicate of the combination of those. Does not hurt to leave this at postponed for now, though, so we can revisit later.
Comment #10
sun#562042: Search for install profiles in sites/[all|site]/profiles folders, and move core profiles into /core/profiles landed. :)
However, this issue is still highly confusing. I actually have no idea what it wants to change/propose. We badly need a proper issue summary here.
The revised issue summary should make sure to clarify crystal clearly how this proposal here relates to (or differs from) the following issues:
#562042: Search for install profiles in sites/[all|site]/profiles folders, and move core profiles into /core/profiles
#1356276: Allow profiles to define a base/parent profile
#295434: Support contrib being placed in profiles/all
Also, there's no way on earth this can be backported ;)
Comment #10.0
sunUpdated issue summary with note about symlinking causing problems with simpletests
Comment #23
smustgrave commentedBrought this up in #yes-no-queue in slack. And @catch brought up
So going to do that but if not the same please reopen updating issue summary with how this is unique.
Thanks!