The module's code could use an update to follow Drupal's coding standards, it's quite messy at the moment.

CommentFileSizeAuthor
#2 nodequeue_extras-n1619400-2.patch10.27 KBjweowu
#1 nodequeue_extras-n1619400.patch9.68 KBdamienmckenna

Comments

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new nodequeue_extras-n1619400.patch9.68 KB

This cleans up the code as much as I could identify.

jweowu’s picture

jweowu commented
StatusFileSize
new nodequeue_extras-n1619400-2.patch10.27 KB

I applied this patch and then ran the module through the coder module's review, and made additional fixes based on that.

Please do commit this. It's good practice and nicer for other devs to work with (and the sooner the module uses proper coding standards, the fewer patches will be affected by the change).

I can't set this RTBC as I've modified the patch myself, but I've certainly reviewed all the code changes from #1. Perhaps if Damien could review the new patch, then between us we could call this RTBC.

azinck’s picture

azinck commented

Sorry to have fallen off the map here, fellas. Thanks for the patches here and elsewhere. I'll be getting them reviewed and committed shortly (and I'm making this comment here to hold myself accountable!).

azinck’s picture

azinck commented
Issue summary: View changes
Status: Needs review » Fixed

Merged to dev (finally).

  • 1ec3fa4 committed on 7.x-1.x 
    Issue #1619400 by DamienMcKenna, jweowu: Use Drupal coding standards.
jweowu’s picture

jweowu commented

Cheers azinck. Nice to see all those patches committed :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.