Going to admin/content and filtering the listing by any language results in a fatal SQL error. The generated SQL query still uses the column name "language" , but it has been changed some time ago to "langcode". The following patch uses "langcode" as it should.

CommentFileSizeAuthor
#8 nodes_admin_language_filter-1635394-8.patch3.17 KBwebflo
#7 filtering_by_language.patch3.78 KBdroplet
#4 1635394-test-500-errors.patch759 bytesdjdevin
nodes_admin_language_filter.patch1.51 KBfloretan

Comments

marcingy’s picture

marcingy commented
Status: Needs review » Reviewed & tested by the community

Looks good

chx’s picture

chx commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs tests

We are clearly missing some testing here if Drupal can fatal out w/o the testbot screaming bloody murder.

djdevin’s picture

djdevin
he/him
Primary language English
Location Philadelphia
commented
Assigned: Unassigned » djdevin
djdevin’s picture

djdevin
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Needs review
StatusFileSize
new 1635394-test-500-errors.patch759 bytes

We are already failing webtest requests that are empty (in WebTestBase::curlExec), does it make sense that we should also be failing responses with a status code of 500?

Maybe there should be something in TestBase::run as well?

djdevin’s picture

djdevin
he/him
Primary language English
Location Philadelphia
commented
Assigned: djdevin » Unassigned

Status: Needs review » Needs work

The last submitted patch, 1635394-test-500-errors.patch, failed testing.

droplet’s picture

droplet commented
Status: Needs work » Needs review
Issue tags: -Needs tests +D8MI
StatusFileSize
new filtering_by_language.patch3.78 KB

Seems like @djdevin uploaded a wrong patch.

Attached the patch with fixes and tests.
** extra language_negotiation_include() fix: #1789750: Fatal error: Call to undefined function language_negotiation_url_prefixes_update()

webflo’s picture

webflo commented
StatusFileSize
new nodes_admin_language_filter-1635394-8.patch3.17 KB

Re-rolled and language_negotiation_include() in language_save is not necessary anymore.

carsten müller’s picture

carsten müller commented

Test passed on my local environment also.
Testing the content interface with some content and filtering by language worked fine

webflo’s picture

webflo commented
Issue tags: +Novice

Marked as duplicate: #1830880: Content list is giving error after filtering with a Language

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community

Great

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Looks good. Committed/pushed to 8.x.

Automatically closed -- issue fixed for 2 weeks with no activity.