Converted the style plugin tests to PSR-0. Means I moved the files, renamed everything and added the name space.

Comments

Status: Needs review » Needs work

The last submitted patch, views-vdc-tests-for-style-plugins.patch, failed testing.

kars-t’s picture

Status: Needs work » Needs review
StatusFileSize
new8.77 KB

New Version after git pull

aspilicious’s picture

Status: Needs review » Needs work
+++ b/lib/Drupal/views/Tests/Styles/PluginStyleUnformattedTest.phpundefined
@@ -2,13 +2,16 @@
+use \ViewsSqlTest;

use ViewsSqlTest

+++ b/lib/Drupal/views/Tests/Styles/PluginStyleUnformattedTest.phpundefined
@@ -29,7 +32,7 @@ class ViewsPluginStyleUnformattedTestCase extends ViewsSqlTest {
+    $htmlDom = new \DOMDocument();

We decided in core to not use backslashes in front of objects in the global namespace. You should "Use DOMDocument" on top of the file

Same for stdClass and the others

kars-t’s picture

Status: Needs work » Needs review
StatusFileSize
new3.95 KB

Rerolling the patch.

Status: Needs review » Needs work

The last submitted patch, views-vdc-tests-for-style-plugins-v2.patch, failed testing.

tim.plunkett’s picture

Version: 7.x-3.x-dev » 8.x-3.x-dev

Please reupload this, it was on the wrong branch.

dawehner’s picture

Status: Needs work » Needs review
StatusFileSize
new3.19 KB

This patch didn't had the renaming, so here is a new version.

aspilicious’s picture

If tests are green this is good to go!

dawehner’s picture

Status: Needs review » Fixed

They run fine, so lets get it in.

Automatically closed -- issue fixed for 2 weeks with no activity.