In the hook_init(), this module calls securepages_redirect(), which calls securepages_match(). securepages_match() is then called in a form_alter, so there can be a case where securepages_match() is called multiple times for the same path. How about we add a static variable to reduce the overhead? Patch will be attached.
// Prevent function from being called multiple times unnecessarily.
static $securepages_match = array();
if (in_array($path, $securepages_match)) {
return;
}
array_push($securepages_match, $path);
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | securepages-match-static-variable-1647760-1.patch | 700 bytes | djbobbydrake |
Comments
Comment #1
djbobbydrake commentedPatch attached.
Comment #2
bisonbleu commentedI posted an issue a while back about too many redirects (https://drupal.org/node/1655264). After applying your patch, my issue is somewhat resolved. Logging out from a secure page (https) no longer generates an error from my browsers. I'll do a little more testing and report back.
Bravo!
Comment #3
astonvictor commentedI'm closing it because the issue was created a long time ago without any further steps.
if you still need it then raise a new one.
thanks