Having just banged my head against this, I wondered if it makes sense to others to rename the Permission to be 'receive' messages rather than 'read messages'

it was counterintuitive to me that the reason i was not seeing the names of people to 'send' messages to was because they did not have the permission to 'read' them. SEND and RECEIVE seem to be two ends of a process. Just a minor suggestion.

The permissions to 'read all messages' makes lots of sense, since they are then able to 'read' messages that they did not 'receive'.

Comments

berdir’s picture

Version: 7.x-1.x-dev » 7.x-2.x-dev

Patches are welcome. Should be enough to just change the label to avoid changing the call all over the place where this permission is used. Note that this is only possible for 7.x-2.x as it breaks existing translations.

petednz’s picture

Thanks for your response and sorry to leave this for so long. but can i just get some clarification.

Is the "read private messages' permission what turns on/off the ability for certain roles to be 'sent a message' ie, if Role=Authenticated does not have "Read private messages' should an Auth user
- show up in the auto-complete
- receive email notifications of the message that is sent.

I expected the answer to both of the above to be 'no' (well the second obviously should follow from the first)

and reading this question I posed back in Aug it would seem like that is what I was experiencing.

But just had it pointed out to me that on a Live site, even though Auth does NOT have 'read pm' permission
- they are selectable in the autocomplete
- they do get sent an email
but
- they do not have access to /messages.

Look forward to your clarification. If things are not behaving correctly on our site then I will endeavour to identify what might be messing with this.

We are using version

and just noticed that on the new user I created for testing purposes (Authenticated - for whom the Perms are
Admin PM - off
Read PM - off
Real All PM - off
Write PM - off
etc

when I go to user/%/edit it showing me

Private messages
Enable private messages - ON
Disabling private messages prevents you from sending or receiving messages from other users.
Receive email notification for incoming private messages - ON

Modules we are using
PrvMsg 7x_1.3
PrvMsg Email Notification
PrvMsg Filter
PrvMsg Limits
PrvMsg roles
PrvMsg Rules integration

ptmkenny’s picture

Status: Active » Needs review
StatusFileSize
new47.41 KB

@#2 I do believe that "read private messages" is intended to be the on/off switch for whether a user can receive private messages. However, there are some bugs related to autocomplete, etc. in the issue queue. Hopefully Berdir can confirm this.

In any case, I am attaching a patch that renames "read privatemsg" to "receive privatemsg," which hopefully makes it much more clear what should be happening.

ptmkenny’s picture

berdir’s picture

berdir’s picture

Status: Needs review » Needs work

Renaming permissions is tricky, this needs an update function that renames existing permission/role assignments.

Agree that this probably makes sense and when we do this, the answer to #138950: META: Permissions can be configured so that users receive messages that they cannot read becomes quite obvious.

ptmkenny’s picture

Status: Needs work » Needs review
StatusFileSize
new24.87 KB

This patch includes Torrance's patch (#16 https://drupal.org/node/1928502#comment-7404828) and an update hook. If it tests out OK I will close this thread and add it to the other.

Status: Needs review » Needs work

The last submitted patch, privatemsg-rename-read-receive-1653462-7.patch, failed testing.

ptmkenny’s picture

Status: Needs work » Needs review
StatusFileSize
new24.87 KB

Re-roll.

Status: Needs review » Needs work

The last submitted patch, privatemsg-rename-read-receive-1653462-9.patch, failed testing.

ptmkenny’s picture

Status: Needs work » Needs review
StatusFileSize
new24.87 KB

Ok, found the cause-- I had an incorrect line at EOF. I mistakenly thought since I could apply the patch locally testbot could deal with it.

Status: Needs review » Needs work

The last submitted patch, privatemsg-rename-read-receive-1653462-11.patch, failed testing.

ptmkenny’s picture

Status: Needs work » Needs review
StatusFileSize
new21.54 KB

Ok, I re-did the patch manually from scratch so hopefully it will apply this time. I also fixed the update hook (I accidentally had it reversed).

Status: Needs review » Needs work

The last submitted patch, privatemsg-rename-read-receive-1653462-13.patch, failed testing.

ptmkenny’s picture

Status: Needs work » Needs review
StatusFileSize
new21.53 KB

Ok, I finally isolated the error-- an extra line at the end of the file.

Status: Needs review » Needs work

The last submitted patch, privatemsg-rename-read-receive-1653462-15.patch, failed testing.

ptmkenny’s picture

Status: Needs work » Needs review
StatusFileSize
new21.7 KB

Re-rolled against latest dev

Status: Needs review » Needs work

The last submitted patch, privatemsg-rename-read-receive-1653462-17.patch, failed testing.

ptmkenny’s picture

Status: Needs work » Needs review
StatusFileSize
new48.04 KB

This time I actually renamed all instances of read to receive.

ptmkenny’s picture

Status: Needs review » Closed (duplicate)

Closing as a duplicate and combining into the patch over here: https://drupal.org/node/1928502