Closed (fixed)
Project:
Drupal.org customizations
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
14 Jul 2012 at 23:16 UTC
Updated:
23 May 2014 at 18:23 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jhodgdonThis patch does the following:
1. Adds some "@todo D7" comments to the code and comments out things that are not able to work now due to not having Git, Project*, or Solr modules available.
2. Gets a few of the pages and blocks working or at least partially working.
More to follow...
Note:
- On the /getting-involved page on dev sites, the spotlight section is empty because they don't have all the nodes. You need to create a node of type forum , in the Community Spotlight forum, promoted to front page.
Things that either were already working or that this patch gets to at least partially working state:
- You can set the dashboard to be the home page or use the default home page.
- /start
- /download
- /community
- /getting-involved
Comment #2
jhodgdonI think that first patch can get committed whenever is convenient - I just bzr reverted, applied the patch, and tested those items that I'd been working on, and it seems to be fine.
Comment #3
drummCommitted this round.
Comment #4
jhodgdonHere is round 2.
In this round, I got some more things working:
- Most of the home page (aside from git/project/solr stuff)
- Page /drupal-7.0 (drupal 7 announcement, with translations)
- Add to Dashboard links on various pages
- Some additional blocks
Things that still need to be tested and/or fixed: Anything marked "@todo d7" in the code. Much of it is depending on Bluecheese, Solr, Project, or other things being ported or closer to working. Some was just "I didn't get to this yet". I think the whole module has either been fixed up or marked with @todo now.
Some specific notes:
- IRC nickname search - I couldn't really test this due to some Bluecheese problem on the dev site I was on
- Forum pages were broken in Bluecheese, so I'm not sure if the ad on forum/34 (hosting) is working.
- There are tons of PHP notices in the log.
- The ad on the right side of the home page is not working. I am not sure why.
- drupalorg_node_view() and drupalorg_node_insert()/update() need updating (taxonomy stuff is not going to work)
Comment #5
drummCommitted.
Comment #6
jhodgdonIf someone else wants to take on the rest of this module port, I won't object. I probably won't get back to it for a while.
Comment #7
jhodgdonI'm working on this again.
Here's what I got done today -- this patch could be committed, or I'll add to it tomorrow (and post an interdiff as well as a new patch).
I was working on the hook_form_alter and the hook_field_access pieces, where I took part of the form_alter function out and made it a field_access piece instead (that's the part that turned off file uploads on some content types for most users). I also ported the rest of the field access hook to d7, though it couldn't be tested without case studies and marketplace up there. I thought this would make a good chunk to review because with more in the patch, it would be less obvious how these changes worked together to keep the same uploads functionality. I also tested it and it does work as planned for both admin and non-admin users, as well as user 1.
Comment #8
jhodgdonHere's another patch, with some further updates (also attaching an interdiff from the previous patch, which is included here).
No real exciting notes here, just some more updates to get some more little pieces of this module working, or in some cases removing @todo lines because the functionality was tested and worked, or adding @todos for additional things to be done after Project* or marketplace or case studies are done.
The biggest new chunk is the search hooks, which take care of IRC nickname searching (which now works on the new-d7 test site).
Comment #9
jhodgdonI reverted and applied this patch on the dev site and I think it's ready to go.
Comment #10
drummCommitted these two
Comment #11
jhodgdonHere's yet another patch. I think at this point everything has been taken care of that can be until the Project*, Solr*, and Git* efforts are done, and case studies and marketplace.
With one exception: ads are not showing up due to some missing JS that is not defining the JS function that actually gets the ad and displays it. This should be easy to fix, but I need to run out, so... not today. Anyway, that's all that can be done on drupalorg/drupalorg until all of these other efforts are done.
The parts that are waiting on those other efforts are also commented with "// @todo D7" comments in the code.
Comment #12
drummCommitted.
Comment #13
jhodgdonHere's one more patch, to fix up a couple of PHP notices.
On the ads, see also #1684992: Clean up ad styles for D7
Everything else has to wait for git, project, solr, marketplace, or case studies, so after this patch is committed you can mark this issue as "postponed".
Comment #14
drummCommitted.
Comment #15
jhodgdonI think the dependencies are fixed and it is time to un-postpone this issue and get the rest of this module working. There should be @todo lines in the code.
Comment #16
drummComment #17
drummI did a pass on the todo comments, mostly confirming that things are indeed working and fixing up some project-related stuff.
The remainder is mostly #1595348: Upgrade the Marketplace feature to D7.
Comment #18
drummComment #19
drummThe remaining todo comments are for #1997998: "Add issues for X to dashboard" links are missing. Everything else looks okay.