Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Pasargad Bank integration for the Drupal Commerce payment and checkout system.
Project page: http://drupal.org/sandbox/mohamadaliakbari/1696668
Git repository: git clone --recursive --branch 7.x-1.x mohamadaliakbari@git.drupal.org:sandbox/mohamadaliakbari/1696668.git commerce_pasargad
Comments
Comment #1
patrickd CreditAttribution: patrickd commentedwelcome,
There is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588 . Then remove the master branch:
As installation and usage instructions are quite important for us to review, please take a moment to make your project page follow the tips for a great project page. Also create a README.txt that follows the guidelines for in-project documentation.
ALL functions must be prefixed with your module name to avoid name collisions!
An automated review of your project has found some issues with your code; As coding standards make sure projects are coded in a consistent style we please you to have a look at the report and try to fix them. Anyway, note that issues found are possibly false positives and fixing all issues is not a requirement for getting through the application process.
Report: http://ventral.org/pareview/httpgitdrupalorgsandboxmohamadaliakbari16966...
We do really need more hands in the application queue and highly recommend to get a review bonus so we can come back to your application sooner.
regards
Comment #2
mohamadaliakbari CreditAttribution: mohamadaliakbari commentedI am trying to do your advises and already fix some of them. As this module is small but useful, please help to make this ready full full project access.
Also as I am using the library provided by bank, Its very hard to follow all Drupal coding standards. Can I skip this step?
And about reviews; sure I know I should help in reviews, I'm trying to find how can I help and what can I review.
Comment #3
Primsi CreditAttribution: Primsi commentedI suggest you to check out how other modules do that. For example:
http://drupal.org/project/commerce_cielo
Comment #4
Primsi CreditAttribution: Primsi commentedChanging status.
Comment #5
aliaric CreditAttribution: aliaric commentedAlso i think it's a good idea to put css file to to css directory and image file to images. Or root.
Comment #6
mohamadaliakbari CreditAttribution: mohamadaliakbari commented@primsi So you think its better to put Bank's files in libraries directory and include it via libraries API?
While Banks library is not available to public and has not any homepage I afraid separating library from module make problems for users.
@aliaric I directory layout as you advise
Comment #7
dwillcox CreditAttribution: dwillcox commentedI'm curious... You say that you're using a library from the bank, but that library isn't available to the public, so you're going to include it with your module.
Has the bank given permission to redistribute their library? If not, there may be a licensing issue here. You'd be publishing code when you don't have the right to do that.
If this is code that you copied from someone else, you really ought to have an attribution, and something about why it's OK to redistribute.
Comment #8
Primsi CreditAttribution: Primsi commentedI had the same concern as dwillcox. Perhaps you can find more info here: http://drupal.org/node/422996.
Comment #9
mitrpaka CreditAttribution: mitrpaka commentedThere is still number of issues regarding to line spaces, indentation and comments.
Please have a look:
http://ventral.org/pareview/httpgitdrupalorgsandboxmohamadaliakbari16966...
Also noticed following:
- stylesheet.css should be renamed to commerce_pasargad.css (@file info missing)
- icon.png should be renamed to commerce_pasargad_icon.png
- pasargad.inc renamed to commerce_pasargad.xxx.inc
If pasargad.inc is library provided by the bank, at least comments about its origin should be added on the top of file. All IPR issues should be clarified - whether you are able to distribute it part of the module or not.
Comment #10
klausiClosing due to lack of activity. Feel free to reopen if you are still working on this application.
If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)