If we move the handful of functions that are at the top of flag.inc, so that it contains only classes, then we can stop including it on every page load and just have the autoloader include it when needed.

Comments

Scyther’s picture

Scyther CreditAttribution: Scyther commented

Is this not a duplicate of #1699752: split flag.inc into different classes ? Or at least it has been done in that patch for that issue.

joachim’s picture

joachim CreditAttribution: joachim commented

It's not, as (IIRC) there are still non-class functions in flag.inc.

BTW this is also postponed until the monster rename lands.

joachim’s picture

joachim CreditAttribution: joachim commented

This also depends on #1524816: Implement D7 hook_hook_info().

(I should maybe do a 3.x roadmap issue.)

Scyther’s picture

Scyther CreditAttribution: Scyther commented

Misread your first post!

joachim’s picture

joachim CreditAttribution: joachim commented
Title: move functions out of flag.inc so it can be autoloaded » move remaining functions out of flag.inc and remove it
Status: Active » Postponed

Hmm ok I'm slightly confused by what *I*'ve written now.

> so that it contains only classes

That's not true -- the classes are gone now.

Basically:

- we moved classes out already
- hook implementations are going to move to a new flag.flag.inc

Therefore this issue is about anything left moving to the module file, and then flag.inc being removed completely!

joachim’s picture

joachim CreditAttribution: joachim commented
Status: Postponed » Fixed

Committed the combined patch at #1735556: [meta] flag performance: db caching, hook_hook_info() and .inc files; this issue gets one commit.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.