Implementation of hook_file_default_displays makes it impossible to export image display settings via features

Now that those commited #4: 1702700.4-media-move-default-display-style-to-db.patch queued for re-testing.

Applied and tested manually, display settings are transferred succesfully and i can successfully export with features.
lets see what bots say before commiting

adding to commit list

I tested the patch in #8 and it works well to export the new image styles with features. It also properly sets the defaults using the hook_install() method.

However, there is a problem with the install hook when used in an installation profile. The problem is that media_install() sets the defaults into the database (using file_save_display) which means that any feature that featurizes these items is going to come in as overridden.

Not sure if to change this issue status, since the patch does do what it needs to do, but I think that "default" behavior here should be reworked and not set directly in hook_install(). For now, here is my workaround which just removes the defaults in my featured module:

<?php

/**
 * Implementation of hook_install
 */
function panopoly_images_install() {

  // Remove initial display settings.
  module_load_include('inc', 'file_entity', 'file_entity.file_api');
  ctools_include('export');

  $default_image_styles = array(
    'preview' => 'square_thumbnail',
    'teaser' => 'medium',
    'full' => 'large',
  );

  foreach ($default_image_styles as $view_mode => $image_style) {
    $display_name = 'image__' . $view_mode . '__file_image';
    $display = array(
      'api_version' => 1,
      'name' => $display_name,
      'status' => 1,
      'weight' => 5,
      'settings' => array('image_style' => $image_style),
      'export_type' => NULL,
    );
    ctools_export_crud_delete('file_display', (object) $display);
  }

  file_info_cache_clear();
}

i see what you are saying

but I think that "default" behavior here should be reworked and not set directly in hook_install()

any insights on how should we do this?
Please open a new issue to discuss this, i committed this

Please feel free to correct me if I'm wrong, but don't we have exactly the same problem in the file_entity module?

Because over there we have file_entity_file_default_displays() and that does a similar thing, no?

LMGTFY... #2192391: Default file entities are not exportable by features (Sibling Issue)