Support for Global Redirect

I've just run into this issue running the latest dev version of Domain Path and latest version of Global Redirect. In my case, paths set using Domain Path don't work, sending the browser into an infinite loop.

My quick and easy (but somewhat hacky?) workout around is to add $_POST['domain_path'] = TRUE to urls set by Domain Path as Global Redirect doesn't run if there's anything set in $_POST. I guess I should add in a check just on the off-chance somebody is POSTing a variable called domain_path. So:

function domain_path_url_inbound_alter(&$path, $original_path, $path_language) {
  if ($source = domain_path_lookup_path('source', $original_path, NULL, $path_language)) {
    if (empty($_POST)) {
      $_POST['domain_path'] = TRUE;
    }
    $path = $source;
  }
}

http://drupal.org/node/1540064 (#3)

It seems to be related.

I'm experiencing the same as @dwatson (and #1411704: Conflict with Domain Access as domain_url_outbound_alter() returns alias). I don't want redirection to another domain, but to another path (the alias). The url_outbound alter in globalredirect messes that up for ALL aliases.

It's not the same issue as #1540064: Redirects between two domains is not working IMO.

I expected the Domain Path aliases to NOT work with Global Redirect (acceptable), but this is somewhat disappointing.

I still don't understand why Global Redirect does that url_outbound alter on the incoming path... Obviously it's changed to an alias... That's what modules do.

@apemantus I'm not experiencing any redirect loops by the way... How did that happen?

I have the same problems with redirect loops for domain_path aliases.
Error occured in domain_path_lookup_path(). This function cache alias paths and source path in single place - $cache['map'] so that a wrong alias is returned for given source if there is cached info.
Patch attached.

That looks good on quick review.

Not work redirect from system path to alias

The reasons are described here http://drupal.org/node/1411704. (hook_url_outbound_alter invoked twice and we need to return domain alias only on the second call)

If patch globalredirect as I described here http://drupal.org/node/1411704#comment-6968340 than we can check the second invocation of hook_url_outbound_alter in domain_path_domain_path()

/**
 * Implements hook_domainpath().
 */
function domain_path_domain_path($domain_id, &$path, &$options, $original_path) {
  // Let's not muck with absolute paths.
  if (!empty($options['absolute'])) {
    return;
  }
  
  /* Globalredirect support
   * Check that hook_url_outbound_alter() invoked by globalredirect and determine the second invocation
   */
  if (isset($options['globalredirect']) && empty($options['globalredirect_domain_path'])){
    $options['globalredirect_domain_path'] = TRUE;
    return $path;
  }
  ...

So that we return domain alias only on the second url rewriting and globalredirect work correctly

Seems reasonable as long as the patch is accepted for globalredirect.

Is #9 addressing a separate issue? The attached patch seemed to work as expected without it.

#9 is the same issue and it decide problem with redirect loops (it is domain_path bug). But redirecting not work (see #11, #12)
Your patch (based on #12) will not have any effect on non patched globalredirect because $options['globalredirect'] is not set always

May be we must patch domain module that implements hook_url_outbound_alter to prevent extra hook_domain_path invocation

Is #9 addressing a separate issue? The attached patch seemed to work as expected without it.

So the solution with the patch from 14 and globalredirect. Does that fix the original issue alone? If not how can we reproduce. I had tested the "Non-clean to Clean" functionality. Apologies if I am missing something.

Your patch (based on #12) will not have any effect on non patched globalredirect because $options['globalredirect'] is not set always

Seems to be a fair assessment. I was stating I would rather be sure that the patch was committed to globalredirect before committing to domain_path.

I'm sorry, perhaps I did not understand you correctly. And sorry for my terrible english )
Yes, #9 seems as separate issue but for me and some others it cause infinite loop redirecting with globalredirect.

I agree, that solution for this issue with the patch from 14 and globalredirect patch
But #9 seems as bug also

In response to #11 there is actually a ticket to add system paths to the white list #1493144: Implement whitelist as in drupal_lookup_path to prevent unecessary lookups so that should be fixed once that is implemented.

Checkout this module: https://www.drupal.org/project/domain_path_rewrite

Every internal path will be automagically redirected to the related domain path with it.