Our styles.css file is now auto-generated, so should we put a warning message at the top of the file to tell people that any changes they make in this file will be wiped out during the next rebirth?

CommentFileSizeAuthor
#4 bluecheese-1706628-v2.patch1.72 KBjhodgdon
#3 bluecheese-1706628.patch1.42 KBjhodgdon

Comments

rupl’s picture

rupl
he/him
Primary language English
commented

Yes, absolutely. This should probably go at the top of every file where we can manage it.

For the same reason we are putting the warning within the file, we cannot add this directly to the CSS files :) It will get wiped out unless we add this to the source (.scss) files.

In order to ensure that the comment does not get wiped out when Sass recompiles, we'll need to use the slash-asterisk style of commenting (/* ... */) within .scss files. Sass comments (double slash //) do not get rendered in the CSS output from Sass.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Assigned: lewisnyman » jhodgdon

I am going to do this today.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Assigned: jhodgdon » Unassigned
Status: Active » Needs review
StatusFileSize
new bluecheese-1706628.patch1.42 KB

I think this patch will do the trick. I added the comment to the partials/global/_base.scss file, and then when I did the compile, the styles.css file got the comment added. We can argue about the wording, but I think it's good enough?

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
StatusFileSize
new bluecheese-1706628-v2.patch1.72 KB

Here's a new patch incorporating suggestions drumm made in IRC.

rupl’s picture

rupl
he/him
Primary language English
commented
Status: Needs review » Fixed

Committed to rev 56

Automatically closed -- issue fixed for 2 weeks with no activity.