Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Our styles.css file is now auto-generated, so should we put a warning message at the top of the file to tell people that any changes they make in this file will be wiped out during the next rebirth?
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | bluecheese-1706628-v2.patch | 1.72 KB | jhodgdon |
| #3 | bluecheese-1706628.patch | 1.42 KB | jhodgdon |
Comments
Comment #1
ruplYes, absolutely. This should probably go at the top of every file where we can manage it.
For the same reason we are putting the warning within the file, we cannot add this directly to the CSS files :) It will get wiped out unless we add this to the source (
.scss) files.In order to ensure that the comment does not get wiped out when Sass recompiles, we'll need to use the slash-asterisk style of commenting (
/* ... */) within .scss files. Sass comments (double slash//) do not get rendered in the CSS output from Sass.Comment #2
jhodgdonI am going to do this today.
Comment #3
jhodgdonI think this patch will do the trick. I added the comment to the partials/global/_base.scss file, and then when I did the compile, the styles.css file got the comment added. We can argue about the wording, but I think it's good enough?
Comment #4
jhodgdonHere's a new patch incorporating suggestions drumm made in IRC.
Comment #5
ruplCommitted to rev 56