Base Building Blocks is a base theme for Drupal 7.x that includes a collection of useful tools for theme development. It makes use of Twitter Bootstrap, Modernizr, and Icon Awesome. It also provides a basic css file structure, a basic page template, and a useful html template. The theme template.php file contains a collection of functions that add classes that Twitter Bootstrap uses to theme certain drupal-generated elements.

Other features include an IOS orientation fix, default media queries for responsive layouts, updated jQuery version, IE7-9 classes for , default Apple touch icons, and aria roles.

I have been working on the theme for awhile, and decided that others might be able to make use of it, as it's been a great resource for me!
The sandbox project page that I set up is here: http://drupal.org/sandbox/patrickocoffeyo/1711522
The Github repo is here: https://github.com/patrickocoffeyo/BaseBuildingBlocks.git

Thanks for reviewing my code!

Files: 
CommentFileSizeAuthor
#8 block.png9.39 KBshanidkv
#8 error.txt4.25 KBshanidkv

Comments

Welcome,

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

OK, I'll find some time to do that. Thanks!

Here is a quick review:

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch (http://drupal.org/node/1127732)

Review of the master branch:

README.txt is missing, see the guidelines for in-project documentation.
Remove all .DS_Store files from your repository.
Remove "version" from the info file, it will be added by drupal.org packaging automatically.

(http://ventral.org/pareview/httpgitdrupalorgsandboxpatrickocoffeyo171152...)

Status:Needs review» Needs work

This looks very interesting, I hope the Base Building Blocks theme will make it into the full projects soon, thanks for making it!

Agree with @ressa at #5. I hope this can be turned into a full project soon.

I'm doing some work to get the d.o repo cleaned up and will be pushing version 2.3.0 onto github soon.
I realize there will be some problems related to the Twitter Bootstrap license, but work is being done to move Bootstrap to an MIT license, so I don't feel any need move bootstrap out of this repository. If it's a showstopper for getting the project on d.o, would you rather wait for Bootstrap to be moved to an MIT license, or utilize Bootstrap as a library?

StatusFileSize
new4.25 KB
new9.39 KB

HI,
Theme looks good
Manual Review:
Please fix these few UI issues
1) please overwrite search block 'form-actions' style
( because its getting alignment issue )

#search-block-form .form-actions{
  padding: 0;
  border: 0;
}

remaining UI styles are looks good for me
2) attached few code sniffer errors. please fix

Status:Needs work» Reviewed & tested by the community

I updated the repo to the latest version. Many of these problems should be resolved. Thanks!

Status:Reviewed & tested by the community» Needs review

Hi pcoffey,

You can't change your own application to RTBC :-). Only someone else who has reviewed your work and is happy with it may do so. Setting to needs review.

Oh, right! Thanks!

Status:Needs review» Needs work

Firstly, please work on these.

Better manual review can be given after fixing issues.

Status:Needs work» Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (found some problems with the project) or "reviewed & tested by the community" (found no major flaws).

Thanks so much! I'm working on a few fixes/features at the moment. When I'm done, I'll push up my changes re-open this when I have finished.