Current Search text items are double escaped when translated

Hi Daniel.

Thanks for posting. These are actually two separate issues and should be their own posts, but I believe they are duplicates so I am closing as such. In addition, they are actually both more relevant to the Facet API project then this one. Please refer to the following issues:

#1728496: Plural text translatable, but no longer shown
#1734730: Taxonomy terms with apostrophe are encoded with "&#39"

Chris

Could you please post a screenshot of the offending tags being converted to characters? I think I understand what you are saying, but I want to make sure we are on the same page before moving forward.

Also, "needs work" status is intended to be used for patches. Please see the Status settings for an issue for more details. Not a big deal, but it helps bm keeps things organized and allows me to respond more efficiently if things are tagged according to these standards.

Thanks in advance,
Chris

Hi Daniel,

Re: the status, not a problem at all, and welcome to Drupal! Glad to have you aboard. We were all new to Drupal.org at one time as well, so I want to help you get the most out of the issue queue as you post against other projects in the future.

Also, thank you so much for the screenshots, I see exactly the problem you are trying to solve now. Let me try to replicate and see if thee is some way to accomplish your goals. The tough part with escaping markup is that if you are too permissive then it becomes an XXS security issue, so let's see if we can get this working in a way that is both secure and configurable.

Much appreciated,
Chris

OK, I see the issue here. Not only is this value being double encoded by Facet API anyways, but it is being tripple encoded when translated via this module. So that's awesome :-(.

To highlight the issue, the first escaping for translated strings will happen in the i18n module on line 643 in the i18n_string_format() function. The second escaping happens on line 45 of the CurrentSearchItemText::execute() method. The third round of escaping happens on line 28 of the theme_current_search_text() function.

Let me think about how to attach this, but there will have to be some fixes in Facet API as well.

Thanks,
Chris

Posted issue against Facet API at #1751514: Current search text items are double encoded to track the patches against the core module.

The attached patch fixes the extra encoding applied during translation.

If you apply the patch above to the Facet API Translate module and the one at #1751514-2: Current search text items are double encoded the the Facet API module, it should solve your use case. If the patches work as expected, feel free to change the status in both issues to "reviewed & tested by the community".

Thanks!
Chris

I didn't refresh before posting :-) Marking as RTBC based on comments in #1741444-11: Current Search text items are double escaped when translated.

Committed at http://drupalcode.org/project/facetapi_i18n.git/commit/57ba40a.