Warnings when attempting to login with an invalid username

I did a quick check and didn't reproduce this in the latest -dev. Please re-affirm it.

Wrong status.

I have been getting this notice as well... like,

Notice: Trying to get property of non-object in _login_security_get_variables_by_name() (line 423 of .../sites/all/modules/contrib/login_security/login_security.module).

from anonymous hits to /user .

Note that I am getting basically the same notice with different line numbers - 418, 419, and 420.

I am running the 7.x-1.1 version of the Login Security module.

Modules I am using which could interact via interactions with the login path or user entities.

• LoginToboggan 7.x-1.3
• Profile 2 7.x-1.3
• Profile Complete Percent 7.x-1.4 - which has a block on the /user page for authenticated users
• CAPTCHA 7.x-1.0-beta2
• reCAPTCHA 7.x-1.9
• Honeypot 7.x-1.14
• Real Name 7.x-1.1

I am seeing the same kind of thing. I am trying to nail down a bit more details than just the errors.

I am running 7.x-1.2. I need to give -dev a go and test again.

 163  23/Apr 20:40  notice   user           Login attempt failed for asdf.
 164  23/Apr 20:40  notice   php            Notice: Trying to get property of non-object in _login_security_get_variables_by_name() (line 418 of /path/to/login_security
 165  23/Apr 20:40  notice   php            Notice: Trying to get property of non-object in _login_security_get_variables_by_name() (line 419 of /path/to/login_security
 166  23/Apr 20:40  notice   php            Notice: Trying to get property of non-object in _login_security_get_variables_by_name() (line 420 of /path/to/login_security
 167  23/Apr 20:40  notice   php            Notice: Trying to get property of non-object in _login_security_get_variables_by_name() (line 423 of /path/to/login_security
 168  23/Apr 20:40  warning  php            Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in EntityCacheControllerHelper::entityCacheLoad() (line 64 of /path/to/drupal/core
 169  23/Apr 20:40  warning  php            Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->cacheGet() (line 355 of /path/to/drupal/core

I did a bit of testing and confirm that the login_security_bogususername.patch patch by @scottsperry does resolve the issue for 7.x-1.x-dev.

I recommend committing this.

Note: This does not fix the array_flip() related warnings. I will create another case for these since I have tracked them down to login_security.

Fixed in 7.x-1.4.