Closed (fixed)
Project:
Util
Version:
6.x-3.x-dev
Component:
System module field closer
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
28 Aug 2012 at 20:16 UTC
Updated:
15 Sep 2012 at 15:21 UTC
Jump to comment: Most recent file
Comments
Comment #1
CydeWeys commentedHere's the .patch that implements this feature.
Comment #2
CydeWeys commentedI defaulted my new feature to FALSE, but I don't think it'd be unreasonable to have it default to TRUE. Let me know your thoughts.
Comment #3
cameron tod commentedPatch looks good and works well. I guess it could be implemented as a plugin in contribs rather than as an add on to system_module, but otherwise, looks great and very useful!
Comment #4
CydeWeys commentedUnfortunately it can't be a separate contrib plugin because the code it uses to do its actual work needs to necessarily reside in the overridden theme_system_modules_theme function, which is already overridden in system_module. If you want to combine the functionality of the two they need to be together in that one definition.
Comment #5
nancydruMenu titles and descriptions are automatically passed through t(), so should that not be used in hook_menu().
I don't like single checkboxes, please change it to radios with
'#options' => array(t('No'), t('Yes'))Please don't mess with my closing parenthesis alignment.
Comment #6
CydeWeys commentedOK, all of those issues have been addressed in this .patch file.
Comment #7
CydeWeys commentedComment #8
nancydruOkay, I'll check it out.
Comment #9
nancydruCommitted, thanks for the patch.