RSS feed for Git commits links to wrong URL

I have observed this with Google Reader as well. Which RSS client have you tested this in?

confirming this, the "comma" should not be there, e.g.

wrong:
http://drupal.org/commitlog/commit/4,378/2373353be7501e8e3900804523b9738...

should be:
http://drupal.org/commitlog/commit/4378/2373353be7501e8e3900804523b97384...

Feed is pulled via Drupal core aggregator module

This is still an issue, any updates?

This is ridiculous, this has been an issue for over a year now!

Yes and it should be a small fix

Looks like the actual problem here is in the versioncontrol.module, which contains the commit log views and RSS feeds.

The URL for the commit is constructed here, which comes from the repo_id column in views, which is defined in versioncontrol.views.inc to use the views_handler_field_numeric handler. This Views handler by default outputs a comma to format the number, so it looks like we just need to disable that in the default commitlog Views here, re-export them, and provide it as a patch.

Here's the patch to fix this in the current D7 View exports. There were some additional changes just by re-saving the View, but I didn't include them. Will provide a D6 patch shortly.

Here is the patch against 6.x-2.x.

FYI I filed a D8 core issue (#2085361: Provide a field handler for serial columns that do not have decimal or separator formatting) with a corresponding Views 7.x-3.x issue (https://drupal.org/node/2085365) that would have helped this because we need a simple handler for the repo_id field.

Thanks Dave

@Dave Reid: Thanks for providing the patches and creating the related issues!

The patches looks good, but sadly it will not solve drupal.org problem, since drupal.org use a different set of versioncontrol view sets defined in other places like drupalorg project.

Before adding the patch to versioncontrol, I will review if repo_id view field is used on other urls generated from views.

For D8, in general sounds like a good idea to have a separate simpler field than numeric.
For D7, maybe is a little late to add a feature, so I will start with the workaround suggested on the patches.
For D6, definitely the workaround is fine.

Sorry for the late response, patches added to d7 and d6, also opened follow ups for vc_project and drupalorg:

• #2270699: Do not use separator on repo_id view field.
• #2270705: Do not use separator on repo_id view field.

Deployed on Drupal.org.

Reopening this ticket as it is not fixed on D.O

See added related issue filed in the D.O infrastructure queue.

The %2C is still in the link causing broken links.

See comment 18

Ok. Just trying to find where the beanstalk ends in this.