Integrate imagefield_focus with the Media module

Thank you bleen18!
But patch at #1 looks strange. Make sure you follow instructions at http://drupal.org/node/1021220/git-instructions/7.x-1.x
For instance, part below should not show up:

+; Information added by drupal.org packaging script on 2012-08-24
+version = "7.x-1.0+2-dev"
+core = "7.x"
+project = "imagefield_focus"
+datestamp = "1345768108"

@bleen18: Thanks for your work. I will try to review it this week.
But again patch looks really strange.
It deletes plenty of lines at the beginning to add some of them again at the end.
Anyway, I think that such a big feature should be added as a sub-module called imagefield_focus_media or media_imagefield_focus, as you prefer.
The patch for imagefield_focus itself should only add minimal changes so that it can accept extensions such as your module while still working the same.
What do you think about this?

Deleted original comment, as it was just me not turning on the focus setting.

Make sure to go to admin/config/media/browser to turn on the focus setting in the media browser.

After turning it on, I actually think the implementation is quite clever and easy to follow. For me this should at least be committed as the first stab on making the implementation work, and then stuff can be tweaked later on.

Thanks for the tip in #9, that sure helped! I didn't do enough testing to call this RTBC, but I tried this patch and it worked as expected.

You can read more about my little experiment with Media, Picture and Imagefield Focus in #1859562-3: add focal point support.

Is there something I'm not getting? So to crop the image that is uploaded in ckeditor, I need to go to the Files list and edit the file?

Ok, so on the File edit page, I find the Focus and Crop textfields but the image below those fields is not appearing in order to set the coordinates.

Is there some other setting in File Entity?

Is this missing anything to get in?

Seems like this would be a great addition.

Whould it be possible to predefine focal point on per-field basis? I have couple of different fields (person photo, article image) and would love to predefine different aspect ratios for them.

I've manually patched this because I can't apply a patch cleanly. However, the media part is working and that is a nice solution. However, it's now not taking new focus or crops -- meaning that I can't re-edit an image I have already edited.

Here's the patched module file.

Some things were not working for me and it looks like it may be because of the last update made right after the last patch was uploaded. This patch should apply cleanly to the most recent dev version of the imagefield_focus module. The commit sha this is tested with is fd5c5df29575b32f08638321abcf02a3fca4d83f (http://drupalcode.org/project/imagefield_focus.git/commit/fd5c5df29575b3...)

Patch in #20 working well for me. Thanks!

Am I doing something wrong ?

1 - Drush dl 7.x-1.x-dev
2 - wget patch #20
3 - git apply patch
4 - drush en module
5 - create a imagestyle using focus crop
6 - Add content having field_image with media selector widget

I don't see anything related to this module except an error message when I click next after uploading an image :

Notice : Undefined index: focus in imagefield_focus_form_file_entity_edit_alter() (line 139 in .../sites/all/modules/contrib/imagefield_focus/imagefield_focus.module

Same message if I go at file/fid/edit

I'm using Media 7.x-2.0-unstable7+54-dev + File entity 7.x-2.0-unstable7+85-dev

This patch works well for me.

@kiwad, it sounds like you're missing the important step discussed in the comments above (e.g., #9):

Make sure to go to admin/config/media/browser to turn on the focus setting in the media browser.

The PHP notice sounds like a small bug, though, most likely introduced by this patch:

+  $settings = variable_get('imagefield_focus_media_settings', array());
+  if ($entity->type == 'image' && $settings['focus']) {

A PHP notice will be generated whenever the variable is using its default value (empty array).

I also see no extra functions popping up after applying the patch
Followed same steps as #22

I have Media 7.x-1.3 installed, but otherwise followed the patch instructions exactly. But I'm not seeing the button appear in the Media browser as the "how to" would suggest. Does anyone know....does this patch not work when Media 7.x-1.3 is in use?

To be clear, the Media browser settings under configuration has the Focus Settings. I enabled focus there, but again, in the Media browser GUI, I see no button for focus settings.

UPDATE: OOPS! I missed the Media 7.x-2 requirement! works great now....This is just the patch I've been looking for!

@David_Rothstein

Thanks! I was indeed missing one step "Make sure to go to admin/config/media/browser to turn on the focus setting in the media browser."

These steps make it work like a charm with media 7.x-2

1 - Drush dl 7.x-1.x-dev
2 - wget patch #20
3 - git apply patch
4 - drush en module
5 - create a imagestyle using focus crop
6 - Add content having field_image with media selector widget
7 - go to admin/config/media/browser to turn on the focus setting in the media browser.

The patch in #20 has some changes that appear to be unrelated to this issue, at least in imagefield_focus.css and imagefield_focus.effects.inc (maybe other places too?). I discovered this while working on another patch that this one conflicted with.

In addition, the PHP notice discussed above is not fixed.

Here's a reroll that removes the changes in imagefield_focus.css and imagefield_focus.effects.inc and also fixes the PHP notice.

Just applied this patch, and all is working well. Thank you!

This patch is working but not with responsive images using picture module (only one image size is cropped using focus data when edit existing images)

Sorry for the false alarm, I had different focus strength on different image styles :(

This patch is not working for me. The form appears on the modal but it doesn't appear to save the settings.

Note I also patched for fixed size.

I am using a Media File field not a Media Image field. The directions in #26 says to use an image field with Media Widget selector, but using a File field seems to be the new standard for Media. I also need to use a file field to allow video.

I'm hoping someone can shed light on this.

Bleen18 -- the coordinates are indeed saving in that sense, yes. But the image style is not working, so I believe they are not saving on the node. For example, I have a style that uses Focus crop then a regular Scale. So that image is scaling but not Focus cropping BUT only on media fields. On regular fields with the same image style, it is working.

thanks for responding!

Updated issue summary.

Here's the patch from #27, now with added hook_field_extra_fields() so you can configure where the focus form elements in the file edit form.

I have no idea why my comment changed the issue text? I clicked the "update this issue" link, wrote a comment and uploaded a file.

Patch from #35 applies cleanly. But shouldn't I get the focus field stuff on admin/structure/file-types/manage/image/fields so I could move them around? The patch places the focus field in the top of the form. It both works when editing a media field and from wysiwyg when uploading - but the focus field is not shown when editing an image in a WYSIWYG area.

It looks like I uploaded the wrong patch file (probably just a copy of #27). Oops.

I've attached a new patch which actually contains my changes as well as the changes from #27.

I don't see the expected changes in the UI. I applied the patch on the latest dev of imagefield_focus and tried using media 7.x-unstable7, 7.x-2.0-alpha3 and the latest dev. But none of them worked. What version should be working together?

Hi Lukas,

I just tested it with the following steps and it all worked as expected. I suspect you might have missed step 3?

1. Download and install media-7.x-2.0-alpha3 (and whatever version of file_entity drush en pulled down).

2. Download, patch (with #38) and install imagefield_focus-7.x-1.x-dev

3. Visit admin/config/media/browser, tick "Enable focus" and save.

4. Visit admin/structure/file-types/manage/image/fields and configure fields.

5. Visit file/add and upload a new image field to test.

6. Configure an image style to use "focus scale and crop" and configuring the Image file type to use it.

In the meantime I switched to focal_point. But yes, I didn't do step 3.

this patch is broken

Rerolled for application after the following are applied:

; Add workbench moderation compatibility - https://www.drupal.org/node/2265973#comment-8774741
projects[imagefield_focus][patch][] = https://www.drupal.org/files/issues/wb-iff-2265973.patch
; Fix JS settings errors related to forms using arrays to contain their primary elements - https://www.drupal.org/node/1896258#comment-7804933
projects[imagefield_focus][patch][] = https://www.drupal.org/files/imagefield_focus_use_data_attr_and_ids_to_fix_js_errors-1896258-6.patch
; Add support for Entity Cache - https://www.drupal.org/node/2050253#comment-8251523
projects[imagefield_focus][patch][] = https://www.drupal.org/files/issues/2050253-clear-file-cache-when-saving.patch
; Crop to exact size - https://www.drupal.org/node/1889542#comment-7702087
projects[imagefield_focus][patch][] = https://www.drupal.org/files/imagefield-focus-maintain-size-1889542-6.patch

Rerolled patch to work with latest dev version of imagefield_focus.

Hi,

I needed to use imagefield focus with a custom file entity type with a custom media browser, so I abstracted patch in #38 to work with custom file entities and w/out the media module dependency. Please review the approach in #2521846: Integrate ImageField Focus with File Entity to see if the efforts between these two issues can be combined/streamlined. Jason.

When I apply https://www.drupal.org/files/issues/wb-iff-2265973.patch, https://www.drupal.org/files/imagefield_focus_use_data_attr_and_ids_to_f..., and https://www.drupal.org/files/imagefield-focus-maintain-size-1889542-6.patch (#2050253: Add support for Entity Cache is now closed), then apply https://www.drupal.org/files/issues/imagefield-focus-media-integration-1..., I get patch conflicts.

Am I missing anything or does the patch need to be re-rolled again?

Has anyone rolled a patch for this since Media's 7.x-2.0-beta1 release? I applied #45 but am seeing no effects.

Same as #48 here.

The same as #48 and #49.
Now i have the latest media(7.x-2.0-beta1+10-dev) and imagefield_focus(7.x-1.0+5-dev), will try to get it work together...