Follow-up: replace all occurence of Drupal.settings with drupalSettings

We're post-feature freeze now, so this can happen. However, since nothing is broken without this being done, don't see why it's critical. Seems like a nice to have?

big & small changes. This kind of changes aren't really need to run crazy manual tests. Errors should be obviously show on browsers console if it had.

#4: drupalSettings.patch queued for re-testing.

Any reason why drupalSettingss is used instead of drupalSettings?

Because someone made a typo in find/replace. ;)

And since such typos are never going to be caught with the testbot, marking as "Needs manual testing."

Mistake, I am packing the correct.

ahh. I forgot the PHP files, lol. Thanks

@kmox83, you should not find & replace. #4 is more than it. :)

It was not the only, in drupal.js it needs to be assigned anyway the Drupal.settings so it can be compatible with the modules which still use that.

Ok, I'm completely new to using drupalSettings so I'm sorry in advance for stupid questions.

First things I noticed after a quick review:

Code in drupal.js is wrapped like this:

(function ($, Drupal, drupalSettings) {
...
})(jQuery, Drupal, window.drupalSettings);

Code in ajax.js however is wrapped like this:

(function ($, window) {
...
})(jQuery, this);

I know that it won't cause troubles but shouldn't that be consistently written?

Basically I should prefer some kind of hierarchical order in the variables passed to (function(..) {})(..);

E.g.:

1. jQuery
2. Drupal
3. drupalSettings
4. ...
5. ...

But that's probably another issue, right?

#17: Yes, that would be another issue. You'd have to talk to nod_ about that and then update the Drupal JS coding standards: http://drupal.org/node/172169.

I agree that would be nice, but it's of course very nitpick: the order is completely irrelevant for the code itself, it's just a very small DX thing.

reload #4 + changed Docs Drupal.settings to drupalSettings.

Re-rolled

I grepped around and found some comments that still reference Drupal.settings

It seems RTBC. No "Drupal.settings" statement found.

Darn, sorry, no longer applies.

Re-rolled.

Darn. Still no longer applies. :\

Now applies well. Let's see what says the testbot and RTBC if green ;)

Testbot can't test anything meaningful with JS changes anyway, so going to get this in while it's hot. :)

Committed and pushed to 8.x. Thanks!

Oops. And change notice.