Default home page for aegir is a 403

We could treat this front page as content. So, add the 'access content' permission to anonymous users, add a new content type, add a default node with a welcome message (or whatever), then point the front page to it... However, this would also mean that this welcome page becomes the home page for logged-in users, rather than the current hosting/sites. Also, by enabling 'access content', we'd be granting access by default to any content added outside the Aegir contents types, where access is controlled natively (largely by the 'clients' functionality, I believe).

So, it looks like treating it as content isn't the way to go. Suggestions?

Something like this looks more promising:

  $items['hosting/front_page'] = array(
    'title' => 'Welcome',
    'page callback' => 'hosting_front_page',
    'access callback' => TRUE,
    'type' => MENU_CALLBACK,
  );

...


function hosting_front_page() {
  return 'front page.';
}

I'd think that we'd want the title and content to be configurable, so we'll need to add some admin config...

This appears to work. It could be a contrib module, I suppose.

Couldn't we leverage the way Drupal itself is doing things now? If the sites page is a problem, why not simply have a regular Drupal welcome page?

Creating a new menu, page and configuration page seems like over-engineering for me.

The way Drupal 6 and 7 handles anonymous users without 'access content'/'View published content' is to present a 403 Access Denied. I'd discussed some of the problems I see with using a node for this in #1. Is there some other method you're suggesting?

Also, the current patch break Drush on the hostmaster, so it obviously 'needs work'.

We need to let Drush through (php_sapi_name() != 'cli'), and it's only relevant on the front page (drupal_is_front_page()).

So, fwiw, here's a new patch.

Okay, I see where you're going with this. This seems fair, although I am worried that making this customizable is over-engineering it a little - people can just change the site_frontpage to a node or other handler if they need to customize that page...

So I would make the code much simpler and get rid of a few variables from your patch. hosting_front_page, _title and_content seem unnecessary. Instead, we should just do a variable_set in the hostmaster.install. The hack in hosting_init() would also be unnecessary...

ping

So, I like what devshop does with the anonymous front_page, turn it into a login page. That's probably a better solution than some arbitrary welcome message. I'll look into porting that, unless there's an objection.

Login page is good, I guess.. But I also like to have a little introduction...

Also, I was thinking that the site listing isn't that useful - maybe the frontpage should be a site creation form?

Fixed in 664f4e1ffd30a0b5.

@anarcat, we can discuss changing the default front_page in another issue, if you like.

yeah, another issue is fine.

i am still not sure we want to have variable_set/get stuff in there - i'd rather have a hardcoded page (but with t() so it can be translated) and people can change the site_frontpage setting to point to another page they can customize if they want to....

i'll commit so you see what i mean, feel free to revert.