Closed (won't fix)
Project:
Apache Solr Common Configurations
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
14 Oct 2012 at 11:11 UTC
Updated:
16 Oct 2012 at 14:58 UTC
Jump to comment: Most recent file
Comments
Comment #1
drunken monkeyPatch attached.
Comment #2
drunken monkeyOops, diffed the wrong part.
Comment #3
nick_vhI'm ok with this - but be aware that these are exact copie from the default of the Solr project. Diffing then will become a little bit more complex.
In any case, I'm ok with this. Let's wait on Chris's opinion
Comment #4
cpliakas commentedHi all.
My opinion on this is that since this is a Solr configuration file, it should conform to whatever standards Solr uses and not Drupal's. Anything that we can do to more closely match the default Solr files the better so that we can more easily update between versions and see the differences. Whitespaces are probably not a huge deal, but my vote would be to stick as close as possible to the default schema.xml file. However, I am not using the files as directly as you guys, so if you think this would be useful, go for it.
Chris
Comment #5
drunken monkeyHm, OK, I guess that makes sense …
It's just that Git complained and I, of course, try to follow the Drupal coding guidelines as possible.
Your point, Chris, about this better following Solr's standards not Drupal's makes sense, though, and the practicality of easier diffing is very probably also more important for comparing with new Solr versions, and not existing Drupal config files.
So, I guess this is a “by design” then …
Comment #6
nick_vh