Active
Project:
Drupal core
Version:
main
Component:
views.module
Priority:
Major
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
25 Oct 2012 at 21:19 UTC
Updated:
15 Feb 2025 at 08:47 UTC
Jump to comment: Most recent
Part of #1864980: [meta] Figure out how to integrate Views into core.
This is appropriate for 8.0.x.
| Issue category | Task because the functionality of these listings is already in core (with custom code) |
|---|---|
| Issue priority | Major because this Meta is about replacing core listings in many places, across systems, and has community consensus for being important. Not critical because we can release 8.0.0 without completing the conversion to views and do it in a later release. Keeping the custom code (not converting a listing) will not cause severe performance or usability regressions. |
| Prioritized changes | A bit, it maybe would reduce fragility by re-using views code and getting rid of custom listing code. |
| Disruption | It will not be disruptive for core/contributed and custom modules/themes because it will not require a BC break/deprecation/widespread changes since changes are isolated to core listing custom code. |
Let's collect all pages/blocks etc. which could be replaced directly with a view, grouped by module.
Comments
Comment #1
larowlanforum blocks
Comment #2
lilou commentedrss
Comment #3
larowlanUser blocks:
Newest users
Who's online
Comment #4
xjmThis is part of (maybe a dupe of) #1864980: [meta] Figure out how to integrate Views into core.
Comment #5
xjmI went through all the blocks from #1535868: Convert all blocks into plugins:
Most likely Views
CategoryBlock).FeedBlock).RecentBlock)ActiveBlock) (Would probably need forum data integration for{forum_index}to avoid potential performance regressions)NewBlock) (as above)RecentBlock)StatisticsPopularBlock)UserNewBlock)UserOnlineBlock)Maybe Views?
PollRecentBlock) but maybe not. (You can make this block with a view, but it's only one record.)ShortcutsBlock? (Would require shortcut intergation)Not Views
An interesting thing about several of these is that the block derivatives in the current patch are filling the role of Views' arguments.
Comment #5.0
xjmupdate
Comment #6
realityloop commentedComments Admin
http://drupal.org/project/better_comments_admin
Comment #7
andyceo commentedIf #1874534: Introduce a dblog / watchdog views integration will be implemented, than there will be another place for views: reports/dblog.
Comment #8
damiankloip commented#6 possible cross over with #1823608: Admin views in core and related.
Comment #9
yesct commentedwhat criteria makes a listing a good candidate for converting to views?
I'm guessing admin/structure/taxonomy would need to stay custom, but it's just a guess.
Comment #10
Crell commentedYesCT: A good candidate for Views, IMO, is:
"Can it be replicated more or less as-is without loss of functionality by a View, without writing additional use-case-specific Views plugins?"
If yes, make it a View.
If no: "Can a generically-useful Views plugin be written such that the first question becomes true?"
If yes, write that plugin and make it a View.
If no, do not make it a View.
Comment #11
xjmComment #12
ParisLiakos commentedAlso. search result listings, see catch's comment here #702940-45: Add option 'Items per page' on admin/config/search/pages
Comment #13
plachGiven #10 what about node comments? Among the rest, this would make #1807322: Filter comments taking into account the current content language not necessary.
Comment #14
Crell commentedplach: That probably would require an in-core hierarchical/nesting style plugin, and for SCOTCH to complete so that it can be "just a block" (that is, a View). If someone were to write that, it would be kinda awesome. :-) (That falls into category 2 from comment 10.)
Comment #15
plachYep, exactly :)
I guess this would be feature, or would it fall into the conversion umbrella?
Comment #16
klonosThe modules/extend page!
Comment #16.0
klonosUpdated issue summary.
Comment #16.1
klonos...adding related issues from the issue summary of #1864980: [meta] Figure out how to integrate Views into core
Comment #17
nigelw commentedPermissions administration
Comment #18
tim.plunkettNeither of those would be able to be listed by views. Unless you write a new query backend.
Comment #19
klonosI know :/ ...
As I said in #1868444-28: Introduce tags[] in module.info.yml file to categorize modules by provided functionality. , we'd first need some way to convert modules to entities (parse the actual modules from the file system and auto-create corresponding entities that are listed in that page).
Comment #20
klonosAlso the brand new "Add block" page (/admin/structure/block/list/block_plugin_ui:[theme]/add) and the "Custom block types" page (/admin/structure/custom-blocks).
Comment #21
dawehner@klonos
Please try to keep this issue on focus. Views is primarily a tool for listing entities, so yeah in theory blocks could be listed by it, and even modules, but that's more a academic project :)
Comment #21.0
dawehner...removing this very issue from the list of related - doesn't make sense.
Comment #22
tstoecklerAdded #1938062: Convert the recent_comments block to a view.
Comment #23
peximo commentedAdded also #1938096: Convert the node comments list to a view
Comment #24
klonos@dawehner, #21:
I missed the fact that #430886: Make all blocks fieldable entities got kicked to D9 back in December. So, yeah academic I guess for D8. Or perhaps pave the way ;)
Comment #25
xjmComment #25.0
xjmUpdated issue summary.
Comment #26
xjmRelated: #113344: Taxonomy term manager view.
Comment #26.0
xjmUpdated issue summary.
Comment #27
larowlanadded https://drupal.org/node/1984588
Comment #27.0
larowlanUpdated issue summary.
Comment #27.1
larowlanUpdated issue summary.
Comment #28
kim.pepperAdded #1986606: Convert the comments administration screen to a view
Comment #28.0
kim.pepperAdded link to 1986606
Comment #28.1
kim.pepperAdded comments admin link under administrative listings.
Comment #28.2
tim.plunkettUpdated issue summary.
Comment #29
oadaeh commentedThis is just an FYI. I started working on the blocks in preparation for tomorrow's sprint. What I've started are:
I didn't see any issues where blocks were being worked on, so if there is one or more, please point me to them.
Comment #30
xjmRelated: #2005166: Create simple file listing under admin/content/file
Comment #31
oadaeh commentedShouldn't the
Node "Recent content" block (RecentBlock)block display be part of this view: #1895160: Convert admin/content to a View, keep a non-views fallback with no bulk operations?The More link at the bottom of the block is a link to admin/content.
Comment #32
xjm@oadaeh, sounds like a great followup issue to add the additional display. :)
Comment #32.0
xjmAdd aggregator conversion issue
Comment #33
xjm@oadaeh, do you have issues for any of the items you list in #29?
Comment #34
oadaeh commentedAfter recreating the "Recent content" view (for the second time), I'm having second thoughts about whether it should be part of #1895160: Convert admin/content to a View, keep a non-views fallback with no bulk operations because I had to override every section to get all the settings correct. (Well, every section except for Header, Footer, and No results behavior.)
Comment #35
oadaeh commentedSorry for the delay. Here they are:
I will update the summary.
Comment #35.0
oadaeh commentedUpdated issue summary.
Comment #36
xjmAlso see #1941830: Convert tracker listings to a view.
Comment #36.0
xjmAdd newly created block issues.
Comment #36.1
xjmUpdated issue summary.
Comment #36.2
klonos...added #2005166 to the list of related issues.
Comment #36.3
klonos...added #1874534 and rearranged issues chronologically also fixed a minor typo.
Comment #37
jhodgdonAdded #2083717: Convert Search Results to Views
Comment #37.0
jhodgdonAdded search module to the list
Comment #38
joelpittetWould it be possible to make forums/forum_list's into table views?
Comment #39
larowlanI don't think we have the views integration, but it would be worth a shot
Comment #40
webchickComment #41
dawehner@larowlan
We do have a basic views integration for {forum_index}
Comment #42
larowlanOk, will take a look
Comment #43
xjmThese conversions are not release-blocking, but they are an important part of the win of VDC, and it would be desirable to have many of them available by beta 1. I have vague memories of discussing this with @dawehner previously and him having some concerns, but I've forgotten now how it went. :)
Comment #44
jhodgdonFYI, I think we've decided to "won't fix" the idea of making search results pages into Views. With #1853536: Reintroduce Views integration for search.module (not supporting backlinks view) people will have the ability to make views with search keywords as the filter (that needs a review, hint hint!) but I think we've decided that the search results page itself is not going to be converted to a view.
I am posting this here rather than updating the issue summary in case it merits further discussion, which I suppose should perhaps happen on the issue itself? (#2083717: Convert Search Results to Views)
Comment #45
xjmComment #46
xjm#2015149: Replace dblog recent log entries with a view
Comment #47
xjmComment #48
xjmComment #49
askibinski commentedShouldn't the custom block library listing also be converted to a view?
/admin/structure/block/block-content
Comment #50
larowlanYes, but we need views integration for block content first, which would be a feature at this stage
Comment #51
effulgentsia commentedIs there a discussion where that was decided? IMO, a content entity type that has non-ephemeral storage, but cannot be queried by Views, is a bug.
Comment #52
jibranHere we go #2375589: Convert custom block library page to views.
Comment #53
dawehnerComment #54
yesct commenteddoing https://www.drupal.org/contributor-tasks/update-allowed-beta
evaluating for https://www.drupal.org/contribute/core/beta-changes
using Drupal 8 beta phase evaluation template https://www.drupal.org/node/2373483
it is not an "unfrozen" only change. it is not on the "priority" list... although maybe "reduce fragility"... I need some help thinking about fragility.
I need some help describing its disruption:
Will it be disruptive for core/contributed and custom modules/themes because it will require a BC break/deprecation/internal refactoring/widespread changes... ?
updated the issue summary. please make any corrections there (and add a comment as to why).
I think then, we can make a similar update on open child issues saying they can proceed as part of this.
Comment #55
jibranCreated #2502151: Add a shortcut block view
Comment #56
xjmThis issue was marked as a beta target for the 8.0.x beta, but is not applicable as an 8.1.x beta target, so untagging.
As disruptive changes and feature additions, these would go into 8.2.x at this point.
Comment #57
woprrr commentedWe should also reflect a naming standard views entities lists. For example I work on "form_mode_manager" now and I have to add a button " LocalAction " on a number of entities . My main problem is really the parameter " APPEAR ON " because I have here "guess" the name of entities listings depending on the entity or I add my local actions. When we use the listings of entities we had a common element
In order to identify the list in question and with his views we have nothing in common ... eg : node = > ' system.admin_content ' media = > ' view.media.media_page_list ... Can we discuss of it here or from right thing? what are your opinions ?
I fully support this initiative ! goal we just need a naming rule I think.
Comment #58
dawehner@woprrr
Please open dedicated issues for this kind of discussions and then feel free to link them from here.
Comment #60
woprrr commentedHi @dawehner,
Thank for your response, sorry for delay but I've focused all my efforts on Media last time. But i restart the developements about form mode / entities now and i 've created issue #2838944: Content entities overviews list standard.
I created too these issue #2838938: Taxonomy term overview with strong links with these issue because Taxonomy term overview need do appear in this issue to change with view overview page.
I'am okay to help my best in this efforts
Comment #65
dqd1.) Convert
/admin/reports/fieldsto a view to change some aspects like the number of shown items per page or to filter and sort for certain things, etc. Therefore we need access to a listing type: fields.2.) We can reach content type already in node views, but I would also vote for getting content type description. This would make it possible to show aggregated content type glossaries with count of entries and some nice description of the content type or we can even replace
/node/addwith a custom view.Comment #66
colan#65: That's #2959299: Add an entity type and a field type filter filter to the Field list report I believe. Added to the list.
Comment #67
matsbla commentedAdding a new idea to #2999938: Replace content translation table with a view
Comment #70
adamps commentedWhat about /admin/structure/views? This could be a view and then people could customise it, for example see #2929931: Add view tags on administrative list of views. Shall I create an issue for it? It looks like we don't currently support a view of views, so it's probably a little tricky.
Comment #71
berdirWe don't support views of config entities, so without https://www.drupal.org/project/efq_views in core there is no point in creating such an issue.
Comment #79
quietone commentedRemoved completed issues
Comment #80
quietone commented