Another easy conversion, this patch moves the cron "page" callback to a controller. It also inlines the access check until #1793520: Add access control mechanism for new router system happens.

Patch coming as soon as I have a nid...

CommentFileSizeAuthor
#4 1843844-cron-route.patch3.55 KBCrell
#1 1843844-cron-route.patch3.52 KBCrell

Comments

Crell’s picture

Crell commented
Assigned: Unassigned » Crell
Status: Active » Needs review
StatusFileSize
new 1843844-cron-route.patch3.52 KB
disasm’s picture

disasm commented 
+++ b/core/modules/system/lib/Drupal/system/CronController.php
@@ -0,0 +1,55 @@
+   *   A

I think this was a typo or a statement that was never finished.

Other than that, the patch looks good architecturally. It's nice and simple. The YAML routing file to specify what controller to run, and a direct port of the current cron code to that controller.

Crell’s picture

Crell commented
Status: Needs review » Needs work 
+++ b/core/modules/system/lib/Drupal/system/CronController.php
@@ -0,0 +1,55 @@
+  /**
+   * Run Cron once.
+   *
+   * @return Symfony\Component\HttpFoundation\Response
+   *   A
+   */

Ayup, I forgot to finish filling that in because I wasn't sure what to say. :-) If you want to reroll with revised text there I can RTBC it. (I won't be able to do so until tonight, so whoever gets to it first, do so.)

Crell’s picture

Crell commented
Status: Needs work » Needs review
StatusFileSize
new 1843844-cron-route.patch3.55 KB

New patch, just fixes the doc.

disasm’s picture

disasm commented
Status: Needs review » Reviewed & tested by the community
Crell’s picture

Crell commented
Priority: Normal » Critical

The denizens of #drupal-contribute suggested making this critical, since it's a procedural blocker for #1793520: Add access control mechanism for new router system, which is also critical. (That issue needs an existing new-style for-reals route to convert, which this issue provides us.)

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Glad to see some new routing action. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.