When you select the max range you cannot set an integer greater than the max NID available for the selected content type. This behavior force users to manually change it every time a new node is created.

I suggest to allow an empty value on the max NID.

Thanks.

CommentFileSizeAuthor
#6 range_validation_google_image_sitemap_1844074.patch5.09 KBastonvictor
#1 1844074-1.patch5.31 KBimiksu

Comments

imiksu’s picture

imiksu
Location Finland
commented
Category: bug » feature
StatusFileSize
new 1844074-1.patch5.31 KB

Patch for this request. I'll change this as feature request since in theory it works as designed.

The patch is against 7.x-1.2.

I see Suhani Jain's commit (a0b9d251cc3c2234d11cd11d4b75747774e7a93e) at repository, but it doesn't remove the Node ID usage restriction.

imiksu’s picture

imiksu
Location Finland
commented
Status: Active » Needs review
joelrotelli’s picture

joelrotelli commented

Very usefull patch, works like a charm, thanks a lot !

tamarpe’s picture

tamarpe commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Works very well, Thank you ! :)

astonvictor’s picture

astonvictor commented
Status: Reviewed & tested by the community » Needs work 
+    // Validate range start and end.
+    if ($form_state['values']['range_start'] > $form_state['values']['range_end']) {
+      form_set_error('range_start', t('Range start should be less than to Range end.'));
+    }

The code above is incorrect. It uses for $query->range($offset, $length);
It should be possible to add $query->range(100, 50);

See range() info.

astonvictor’s picture

astonvictor commented
Status: Needs work » Needs review
StatusFileSize
new range_validation_google_image_sitemap_1844074.patch5.09 KB