Product reference fields doesn't actually validate user input, but instead strip anything that cannot be found.

This is very poor behavior for two reasons.

1. It's possible to bypass a required product reference field, by entering a random string (bug).
2. By not giving the user any feedback that he/she entered an invalid value the user can thing, that what he entered was ok. since it can be quite hard to see the values when there are multiple values entered, this is very bad UX.

I think the best option would be to require all values entered to actually be valid.

Files: 
CommentFileSizeAuthor
#1 1844552-validate-product-reference-field.patch680 bytesgoogletorp
PASSED: [[SimpleTest]]: [MySQL] 3,570 pass(es).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new680 bytes
PASSED: [[SimpleTest]]: [MySQL] 3,570 pass(es).
[ View ]

And the patch that fixes this by doing the validation.

Status:Needs review» Fixed

Easy enough; tweaked the message and committed.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.