Missing link descriptions in responsive toolbar.

Problem/Motivation

D7 toolbar has tooltips on its links. D8 does not. This applies to top level links and deep links as well.

Proposed resolution

To be determined.

Remaining tasks

To be determined.

User interface changes

To be determined.

Report by moshe weitzman

Meta issue: #1846970: [meta] Responsive Toolbar follow-ups

Comment	File	Size	Author
#20	1853324-missing-link-desc-11.patch	2.27 KB	RyanPrice
#11	1853324-missing-link-desc-11-test-only.patch	1.83 KB	kim.pepper
#11	1853324-missing-link-desc-11.patch	2.28 KB	kim.pepper
#3	missing-link-desc-1853324-3.png	11.41 KB	sandipmkhairnar
#3	missing-link-desc-1853324-3.patch	457 bytes	sandipmkhairnar

Comments

shyamala’s picture

Comment #1

shyamala commented 5 December 2012 at 04:08

Issue tags:

+toolbar-followup

Adding tags toolbar-followup

Log in or register to post comments

jessebeach’s picture

Comment #2

jessebeach commented 6 March 2013 at 16:51

Issue tags:

Adding tag novice

Log in or register to post comments

sandipmkhairnar’s picture

Comment #3

sandipmkhairnar commented 9 March 2013 at 07:06

Status	File	Size
new	missing-link-desc-1853324-3.patch	457 bytes
new	missing-link-desc-1853324-3.png	11.41 KB

Added missing link description.

Missing link toolbar

Log in or register to post comments

sandipmkhairnar’s picture

Comment #4

sandipmkhairnar commented 9 March 2013 at 07:08

Status:

Active

» Needs review

Log in or register to post comments

cgalli’s picture

Comment #5

cgalli commented 9 March 2013 at 11:25

Status:

Needs review

» Reviewed & tested by the community

manually tested, looks good
automated test missing

Log in or register to post comments

rteijeiro’s picture

Comment #6

rteijeiro commented 9 March 2013 at 11:28

Tested the patch and works as expected. The links appears in the toolbar.

Syntax seems ok. Just RTBC.

Log in or register to post comments

Comment #7

Anonymous (not verified) commented 9 March 2013 at 11:29

I have reviewed and applied the patch, it's working fine for me.

Log in or register to post comments

klonos’s picture

Comment #8

he/him

English

90% Melbourne, Australia - 10% Larissa, Greece

commented 16 March 2013 at 21:40

Status:	Reviewed & tested by the community	» Active
Issue tags:		+Needs tests

...as per #5. Other than that, RTBC from me too.

Log in or register to post comments

jessebeach’s picture

Comment #9

jessebeach commented 9 April 2013 at 15:27

Adding novice-html, novice-php tags.

Log in or register to post comments

jessebeach’s picture

Comment #10

jessebeach commented 9 April 2013 at 15:28

Issue tags:

+html-novice, +php-novice

Oops, got the order of the terms backwards. Should have been html-novice, php-novice to match js-novice and css-novice.

Log in or register to post comments

kim.pepper’s picture

Comment #11

English

🏄‍♂️🇦🇺Sydney, Australia

commented 9 April 2013 at 22:24

Status:

Active

» Needs review

Status	File	Size
new	1853324-missing-link-desc-11.patch	2.28 KB
new	1853324-missing-link-desc-11-test-only.patch	1.83 KB

Added test.

Log in or register to post comments

kim.pepper’s picture

Comment #12

English

🏄‍♂️🇦🇺Sydney, Australia

commented 10 April 2013 at 01:40

Hmm. Test-only fails locally.

Log in or register to post comments

kim.pepper’s picture

Comment #13

English

🏄‍♂️🇦🇺Sydney, Australia

commented 10 April 2013 at 10:13

#11: 1853324-missing-link-desc-11-test-only.patch queued for re-testing.

Log in or register to post comments

Comment #14

trevjs commented 24 May 2013 at 17:46

Reviewed and tested.

Log in or register to post comments

Comment #15

trevjs commented 24 May 2013 at 17:46

Status:

Needs review

» Reviewed & tested by the community

Log in or register to post comments

tstoeckler’s picture

Comment #16

he/him

German

Essen, Germany

commented 27 May 2013 at 15:27

Status:

Reviewed & tested by the community

» Needs work

If the tests-only patch does not fail, the the tests apparently need work.

Log in or register to post comments

kim.pepper’s picture

Comment #17

English

🏄‍♂️🇦🇺Sydney, Australia

commented 2 June 2013 at 00:16

Status:	Needs work	» Needs review
Issue tags:	-Needs tests, -Novice, -toolbar-followup, -html-novice, -php-novice

#11: 1853324-missing-link-desc-11.patch queued for re-testing.

Log in or register to post comments

kim.pepper’s picture

Comment #18

English

🏄‍♂️🇦🇺Sydney, Australia

commented 2 June 2013 at 00:16

Issue tags:

+Needs tests, +Novice, +toolbar-followup, +html-novice, +php-novice

#11: 1853324-missing-link-desc-11-test-only.patch queued for re-testing.

Log in or register to post comments

Comment #19

RyanPrice commented 22 June 2013 at 14:30

Assigned:

Unassigned

Working on reroll

Log in or register to post comments

Comment #20

RyanPrice commented 22 June 2013 at 15:35

Status	File	Size
new	1853324-missing-link-desc-11.patch	2.27 KB

rerolled patch

Log in or register to post comments

Comment #21

RyanPrice commented 24 June 2013 at 20:00

Assigned:

» Unassigned

Log in or register to post comments

rteijeiro’s picture

Comment #22

rteijeiro commented 24 June 2013 at 21:27

Status:

Needs review

» Reviewed & tested by the community

Patch applies well and everything seems to work well (we have links description again). Also the test looks good. Maybe RTBC?

Log in or register to post comments

Comment #23

he/they

English

🇪🇺🌍

commented 27 June 2013 at 09:28

Status:

Reviewed & tested by the community

» Fixed

Committed 0e0a407 and pushed to 8.x. Thanks!

Log in or register to post comments

Comment #24

11 July 2013 at 09:31

Automatically closed -- issue fixed for 2 weeks with no activity.

Log in or register to post comments

Comment #24.0

(not verified) commented 11 July 2013 at 09:31

Issue summary:

filing out the issue summary details under different headings and linking to meta issue

Log in or register to post comments