I've created a module commerce_extra_price. This module allows ordering of price components in cart pane and allows printing discount line item in its own line. I discover your module later.
Are you agree to merge my module in yours ?

Comments

ikos’s picture

Status: Active » Needs review
StatusFileSize
new5.31 KB

Hi,

Sorry it's take me a while to look at this.

I have looked at what your module does and can see some issues in the queue for this module that are asking for things you have done here.

The attached patch does the following:

  1. Merges in the code from Commerce Extra Price to allow for reordering of price components in the checkout pane.
  2. Adds to this code to ensure the Total is always at the bottom.
  3. Adds new configuration options to allow you to optionally hide specific components.

I have not merged the discount on one line part as Bojan commented that it should be part of the discount module.

Can you have a look and see if the patch works for you?

many thanks

Richard

MarcElbichon’s picture

I've tested your patch with success but i have to do some minor changes :

  • Theme declaration is missing
  • some notice errors are printed.

Here's a new patch correcting these malfunctions.

matsjacobsson’s picture

I would love to have this functionallity included in the module too. Whats the status for this?

Cheers! /Mats

summit’s picture

Hi, me too.
WOuld love to see this committed.
Will test this patch and report back.
Does anybody have latest dev including this patch as zip? Than I can test easier.
Thanks for reply in advance,
greetings,
Martijn

summit’s picture

Version: 7.x-1.1 » 7.x-1.x-dev
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new22.09 KB

Hi,
I build the module inclusive patch myself and it is working great. Great to be able to select the different components to be included in the price myself.

See attached .txt file. Remove .txt and copy over latest dev.
Thanks for committed this in advance!
Greetings, Martijn

discipolo’s picture

patch from #2 didnt apply for me. this is the same patch again.

discipolo’s picture

after applying this patch where should i look for new configuration options allowing to hide or reorder price components?
EDIT: found it by looking at the code: admin/commerce/config/checkout/form/pane/cart_contents

discipolo’s picture

the interface still shows up but it doesnt reorder components anymore for me, not sure what changed yet

joelpittet’s picture

Status: Reviewed & tested by the community » Needs work

Let's put this to needs work.

heliogabal’s picture

I applied path #6 just now and it works for me.

psf_’s picture

After apply the path #6 we need flush the cache.