From this weeks stats:

tim.plunkett	810
Crell	328
dawehner	327
sun	320
jhodgdon	290

I appreciate being "first", but there is no possible way I could have that many commits.

CommentFileSizeAuthor
#7 drupal-8.0.x-dev-participation-by-commits.yml.zip13.64 KBmarvil07
#6 fix-duplicates-try-2.patch5.53 KBmarvil07
#4 fix-duplicates-try-1.patch6.68 KBmarvil07

Comments

marvil07’s picture

marvil07 commented

Grrh, sorry for the big delay here, I blame notifications to not autosubscribe me to projects I create.

Please, let me know where exactly that numbers come from(stat filename). Please notice that there is more than one criteria.

I would be happy to investigate in this week stats.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

From this week's drupal8-dev-participation-by-commits-no-maintainers.txt:

tim.plunkett	827
dawehner	338
sun		334
Crell		330
jhodgdon	300

By my count, I'd guess I'm under 400, probably closer to 350. 827 is definitely wrong.

xjm’s picture

xjm
she/her
Primary language English
commented

See also: #1816578: Commit authorship

marvil07’s picture

marvil07 commented
Title: Miscalculation of results » Au
Status: Active » Needs work
StatusFileSize
new fix-duplicates-try-1.patch6.68 KB

Uhm, I have not yet found the reason, but yep, something is wrong.

Based on:

$ git log --author="Tim Plunkett" --oneline 34c6cdd66bac4c7b0c262cc2873c88a65f7b591c..8.x |wc -l
142
$ git log --grep="tim.plunkett" --oneline 34c6cdd66bac4c7b0c262cc2873c88a65f7b591c..8.x |wc -l
337

I would say current number on drupal8-dev-participation-by-commits-no-maintainers.txt should be 479, and it's 861.

marvil07’s picture

marvil07 commented
Title: Au » Miscalculation of results on commit count
marvil07’s picture

marvil07 commented
StatusFileSize
new fix-duplicates-try-2.patch5.53 KB

Another try at this, but not yet producing the results I expect.

What is new here: maps git person names with drupal.org usernames at parsing time to avoid duplicates in the same commit.

But it seems like that was not the problem.

marvil07’s picture

marvil07 commented
Issue summary: View changes
Status: Needs work » Fixed
StatusFileSize
new drupal-8.0.x-dev-participation-by-commits.yml.zip13.64 KB

I have been rewriting the base, so hopefully this is now better by design, I removed python script in favor of php.

But I think I know now what is the problem, see git log --committer="Plunket" --oneline 34c6cdd66bac4c7b0c262cc2873c88a65f7b591c..8.0.x

It seems like drupal core added commits from views itself, so I guess that's where extra commits are coming from.

Marking this as solved since in current dev branch I see results as they should be.
See attached file for current dev branch run of commit stat file.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.