Convert language_count to the state system.

This is failing because we need a memory keyvalue store in early bootstrap. I added that and than the installer proceeds to the database settings page. After filling in the correct data it blow up again with the message: "keyvalue.memory" is not available.

Thats because we had to change the default to keyvalue.memory to make the installer work but when we enter the database settings a new container will be build that contains the database keyvalue store (*I think*) so we have to clear the keyvalue.memory default so that it takes the databse one.

I tried that but it still tells me "keyvalue.memory is not defined". If someone else can figure out where we have to add an aditional check or where we have to reset/rebuild something please let me know (or fix the patch yourself :p).

They had similar problems in #1804380: convert color variables to config/state, see the patch there.

Am working on this on the CodeSprint: https://drupal.org/node/2009672

try to reroll

Adding tag and changing status

+++ b/core/includes/bootstrap.incundefined
@@ -2514,7 +2514,9 @@ function language_multilingual() {
+  $language_count = state()->get('language.count');
+  $language_count = !empty($language_count)? $language_count: 1;

+++ b/core/lib/Drupal/Core/Language/LanguageManager.phpundefined
@@ -135,7 +135,9 @@ public function reset($type = NULL) {
+    $language_count = state()->get('language.count');
+    $language_count = !empty($language_count)? $language_count: 1;

+++ b/core/modules/language/lib/Drupal/language/Tests/LanguageListTest.phpundefined
@@ -119,7 +119,9 @@ function testLanguageList() {
+    $language_count = state()->get('language.count');
+    $language_count = !empty($language_count)? $language_count: 1;

@@ -133,7 +135,9 @@ function testLanguageList() {
+    $language_count = state()->get('language.count');
+    $language_count = !empty($language_count)? $language_count: 1;

+++ b/core/modules/locale/lib/Drupal/locale/Tests/LocaleUninstallTest.phpundefined
@@ -115,7 +115,8 @@ function testUninstallProcess() {
+    $language_count = state()->get('language.count');
+    $language_count = !empty($language_count)? $language_count: 1;

replace with $language_count = state()->get('language.count') ?: 1;

Fixed those changes.

As for the KeyValue storage problems, I suppose that they could've already been solved by the patch from https://drupal.org/node/1804380 that was commited in feb.2013. If not, I'll add some code to "core/includes/install.core.inc"

Unforunately it still needs work. I've ran into coke and egg issue. I can't make a change to the LanguageManager.php file.

/**
* Whether already in the process of language initialization.
*
* @todo This is only needed due to the circular dependency between language
* and config. See http://drupal.org/node/1862202 for the plan to fix this.
*
* @var bool
*/

But even besides that some tests fail for now.

Re-rolling #11

#14: 1856976-language_count_to_state-drupal8-14.patch queued for re-testing.

Re-roll after #1947720: Use Drupal::state() to replace state()
Fixed install, @todo language manager requires 'state' service injection

This kind of injection does not work.

EDIT we can use optional injection

The container is not accessible somehow

Another approach

Fixed a bit of cache troubles.
The state service is optional

#24: language-state-1856976-24.patch queued for re-testing.

+++ b/core/core.services.ymlundefined
@@ -185,6 +185,7 @@ services:
+    arguments: ['@?state']

I try to figure out why we couldn't use a memory based key value store during validation.

+++ b/core/lib/Drupal/Core/Language/LanguageManager.phpundefined
@@ -46,6 +54,16 @@ class LanguageManager {
+   *
+   * @param KeyValueStoreInterface $state

Should be the full namespace.

+++ b/core/lib/Drupal/Core/Language/LanguageManager.phpundefined
@@ -46,6 +54,16 @@ class LanguageManager {
+   *   The state keyvalue store.

Let's also document that it is optional.

No reason for conversion to add new service for install time.
Memory based storage would be added in #1862202: Objectify the language system because it changes a way like language manager registred.
So for now just simple check for that

+++ b/core/lib/Drupal/Core/Language/LanguageManager.phpundefined
@@ -136,7 +154,11 @@ public function reset($type = NULL) {
   public function isMultilingual() {
-    return variable_get('language_count', 1) > 1;
+    if (!isset($this->state)) {
+      // No state service in install time.
+      return FALSE;
+    }
+    return ($this->state->get('language_count') ?: 1) > 1;

Here's a check for install time and absence of the state

Well, isn't it a reason that we hack around stuff which is actually not needed if we do it properly,
especially because we already know how to do it properly?

@dawehner Because this task is independent from #1862202: Objectify the language system so just trying to not duplicate a work

#28: language-state-1856976-28.patch queued for re-testing.

There we go.

$javascript_parsed_count = count($this->container->get('state')->get('system.javascript_parsed') ?: array());

slightly unrelated but I get why you're doing this in there as the service is injected now. Looks good to me otherwise...

Good to go!

Committed 566ebfd and pushed to 8.x. Thanks!