As a follow-up to #1806022: Views' text color does not have sufficient contrast, an asterisk that denotes a required field is styled in system.theme.css with

.marker, .form-required {
    color: red;
}

required.png

CommentFileSizeAuthor
#6 1862966-6.patch399 bytesjibran
#3 f00-to-ee0.png40.31 KBdead_arm
#3 f00-on-fff.png69.93 KBdead_arm
#3 ee0-on-fff.png70.25 KBdead_arm
#3 core-systemcsscleanup-1862966-3.patch399 bytesdead_arm
#1 core-systemcsscleanup-1217044-24.patch402 bytesdead_arm

Comments

dead_arm’s picture

dead_arm
she/her
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new core-systemcsscleanup-1217044-24.patch402 bytes

Moved from parent issue #1217044: Clean up the CSS for System module so it gets visibility.

Patch to change marker and form-required red to #ee0000. Passes WCAG AA on white.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Can we keep the shorthand notation #e00, please? :)

RTBC with that adjustment.

dead_arm’s picture

dead_arm
she/her
Primary language English
commented
StatusFileSize
new core-systemcsscleanup-1862966-3.patch399 bytes
new ee0-on-fff.png70.25 KB
new f00-on-fff.png69.93 KB
new f00-to-ee0.png40.31 KB

Re-rolled patch :)

Screenshots to show that the difference between the reds is basically imperceptible, but #f00 fails and #ee0 passes.

Reds:
f00-to-ee0.png

Test of #f00 on #fff:
f00-on-fff.png

Test of #ee0 on #fff:
ee0-on-fff.png

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Hah, you changed it to #ee0, which is ~beige ;) — can we quickly change it to #e00 and call this done? :)

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Needs work 
+++ b/core/modules/system/system.theme.css
@@ -123,7 +123,7 @@ input.form-radio {
-  color: #f00;
+  color: #ee0;

Should be #e00

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
StatusFileSize
new 1862966-6.patch399 bytes

patch

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Needs review

.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community

Thanks! :)

dead_arm’s picture

dead_arm
she/her
Primary language English
commented

Argh! At least it's fixed now :)

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

Automatically closed -- issue fixed for 2 weeks with no activity.