There are several issues in the queue, related with Flag 3.x compatibility.
Each one I tested had some portions were working but had something else broken.
I ended up applying those patches and testing against Drupal 7.17 and Flag 7.x-3.0-alpha4
Fixed uninstallation.
Fixed broken views handler.
...
See the other issues related with this one:
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | aaaflag.jpg | 41.3 KB | metroecho |
| #6 | flag_friend_error.png | 6.34 KB | h3rj4n |
| #6 | interdiff.txt | 573 bytes | h3rj4n |
| #6 | flag_friends-flag_3x_compatibility-1866040-6.patch | 29.03 KB | h3rj4n |
| #5 | flag_friends-flag_3x_compatibility-1866040-5.patch | 28.86 KB | h3rj4n |
Comments
Comment #1
osmanAttached patch is created for the 7.x-1.x branch.
Comment #2
socketwench commentedLooks great, except for some failures in the automated tests. Thankfully, it's a single line fix.
Comment #3
socketwench commentedScratch that. The tests were another issue.
Here's a re-roll. It blows up the tests spectacularly, so we still have a bit of work ahead of us.
Comment #4
Sinan Erdem commentedHello and thanks for the patch on comment #3. I applied it to the latest dev version. It seems to work fine.
Just one thing: When I want to display Flag Friend link on a view, I first add a relationship: Flag Friend: friend (by any user)
Then, among those fields:
Flags: Flag link -> works
Flag friend: Flag friend links -> Doesn't work.
Comment #5
h3rj4n commentedI wasn't able to apply the patch from #3 so I rerolled the patch.
Comment #6
h3rj4n commentedA view steps I had to take to get it all working:
1. Apply the patch attached with this comment.
2. Enable the module (if you already have enabled it, uninstall it completely)
3. Enable the Friend flag on the admin page of the flag: '/admin/structure/flags'.
Now it works as it should be (I guess).
I solved the following error with this patch:
Comment #7
h3rj4n commentedComment #8
metroecho commentedFirst time setting this up, started with flag 7.3 had errors , then uninstalled and loaded Flag 7.2 still had errors , I uninstalled both flag and flag friend, removed them .. can see nothing in the database for flag yet I still get this
Comment #9
metroecho commentedok deleted some records in view that were related then extracted again Flag the Friend tab went away and when I enabled Flag Friend it looks like its working as it should be. I have no idea why the Friend tab would still show and function while the modules are not there.
Comment #10
socketwench commentedI have no idea how we're going to reroll this when https://drupal.org/node/1433122 gets in...
Comment #11
cromian commentedHI everyone is patch #6 the better option?
Comment #12
socketwench commented@Cromian It might apply to the git version of the module. It's been a while since I've worked on this issue.
Comment #13
socketwench commentedWhile I didn't use the patches above, I *did* fold 3.x compatibility into https://drupal.org/node/1433122
The DEV version is not compatible with Flag 3.x: http://drupalcode.org/project/flag_friend.git/commit/48d0c99