Closed (fixed)
Project:
Examples for Developers
Version:
8.x-1.x-dev
Component:
DBTNG Example
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
17 Dec 2012 at 05:01 UTC
Updated:
12 Jun 2014 at 23:20 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
marvil07 commentedFirst functional version.
Comment #2
mile23Thanks, marvil07.
Right off the top...
There are a couple spots where it still says 'Drupal 7.'
Comment #3
mile23Forgot to set to 'needs work.'
Also: #1861598: Examples for Drupal 8 needs relatively stable feature set
Comment #4
marvil07 commentedOk, I've made a pass on all strings, and I think now it is OK.
Also, coder tell me(on D7) it's OK from coding standards perspective.
Comment #5
marvil07 commentedAdded to 8.x-1.x!
Comment #6
marvil07 commentedRe-opening as follow-up to conform documentation standards (see #1880976-4: [meta] Port examples (including submodules) to D9.4+):
Comment #7
marvil07 commentedWow, a lot of details to review, I have been reading http://drupal.org/coding-standards/docs again. It grew up a lot since the last time I checked it.
Uncompleted doc review patch attached.
Comment #8
wesleydv commentedCreated a patch that fixes the failing simpletests, this will unblock testing of other patches against the 8.x branch.
Included patch from #7 (by marvil07).
Still needs a lot of changes to be a proper Drupal 8 example.
Changing status to allow the testbot to pick it up.
Comment #9
marvil07 commented@wesleydv: Thanks for the patch!
I have just added your new fix to 8.x-1.x, but I'm still leaving here the docs's patch here pending for more work.
Also, taking the chance to update the issue title to reflect better the status.
Comment #10
rteijeiro commentedIt seems @marvil07 is not working on this issue so I will try to finish it. If I'm wrong just let me know ;)
Comment #11
marvil07 commentedYes, I usually set the Assigned issue field when I'm doing something, so feel free to continue with it ;-)
Comment #12
wesleydv commented@rteijeiro you might also want to look at https://drupal.org/node/2074243
Comment #13
mile23Just want to be sure and reference #2074243: Convert DBTNG to OOP from here.
Comment #13.0
mile23Change origin issue to point at d8 port for examples issue inside this module queue
Comment #14
mile23Feel free to assign yourself back if you're still working on it.
Comment #15
socketwench commentedFixed routing, removed hook_menu(), updated form and controller base classes.
Comment #17
socketwench commentedFixes to hook_help().
Comment #18
mile23Did they change it again?? :-)
Comment #19
mile23I'm not sure about this, because of https://drupal.org/node/2250345
The example code there uses Request.
Also, I just applied this patch and after installing the module I get this error: Recoverable fatal error: Argument 2 passed to dbtng_example_help() must be of the type array, object given in dbtng_example_help() (line 68 of modules/examples/dbtng_example/dbtng_example.module).
Kind of a mystery to me how it passed the test.
Here it is with the Request object.
Comment #20
mile2319: 1868178_19.patch queued for re-testing.
Comment #22
mile23And we're calling that fixed.
Thanks, folks!