See #1880976: [meta] Port examples (including submodules) to D9.4+

CommentFileSizeAuthor
#1 0001-Issue-1882676-Port-page_example-to-D8.patch13.95 KBmarvil07

Comments

marvil07’s picture

marvil07 commented
Assigned: marvil07 » Unassigned
Status: Active » Needs review
StatusFileSize
new 0001-Issue-1882676-Port-page_example-to-D8.patch13.95 KB

Here the port!

marvil07’s picture

marvil07 commented
Status: Needs review » Fixed

Added to 8.x-1.x!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

marvil07’s picture

marvil07 commented

Added a follow up to use new routing system.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Closed (fixed) » Needs work

That looks great.

But I'd really like to see phpunit tests. For instance, the tests never see the AccessDeniedHttpException, even though it's declared as a dependency. Viz: http://phpunit.de/manual/3.2/en/writing-tests-for-phpunit.html#writing-t...

I don't mean convert everything to phpunit. I *do* mean: Add phpunit tests that cover dependencies. I'll have to write up a policy issue about this.

marvil07’s picture

marvil07 commented
Status: Needs work » Closed (fixed)

Ok, can please you please elaborate on the issue I have just opened: #2022601: Use phpunit on page example

IMHO current code here is good enough to start, so let's do the rest on individual issues.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Closed (fixed) » Fixed

As far as the PHPUnit stuff, please ignore. D8's autoloader can't find the test class in a nested directory like the one for Examples. It will have to wait. I'm unable to find an issue on it.

Also, never set the status to 'closed (fixed).' Just 'fixed' is good. :-)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.