Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
The theme_install_page() function simply calls drupal_add_http_header('Content-Type', 'text/html; charset=utf-8');
and then returns the maintenance page.
Additionally, it is identical to theme_update_page.
Attached patch removes theme function, and relocates functionality.
Related:
#1885850: Remove theme_update_page()
#2177655: Replace theme() with drupal_render() in install.core.inc
Comment | File | Size | Author |
---|---|---|---|
#23 | 1885714-23-proof-of-concept.patch | 32.43 KB | Adev22 |
#18 | 1885714-18-proof-of-concept.patch | 9.68 KB | jamesquinton |
#16 | 1885714-16-proof-of-concept.patch | 6.92 KB | star-szr |
#13 | Screen Shot 2014-02-08 at 09.58.12.jpg | 85.17 KB | LewisNyman |
#12 | core-remove-theme_install_page-1885714-12.patch | 7.16 KB | chakrapani |
Comments
Comment #0.0
jenlamptonclarify, cleanup
Comment #0.1
jenlamptonlink to identical theme func
Comment #1
nod_tag
Comment #2
star-szrI don't think Seven should include mobile.install.js on all maintenance pages. I was able to get Seven to only include it on the install pages by using drupal_installation_attempted(), but that function returns FALSE on the "Installation complete" step so mobile.install.js is not included on the last step. Any suggestions appreciated.
Comment #4
star-szr#2: 1885714-2.patch queued for re-testing.
Comment #5
star-szrComment #6
LewisNyman CreditAttribution: LewisNyman commentedRELATED: #1337554: Develop and use separate branding for the installer
Comment #6.0
LewisNyman CreditAttribution: LewisNyman commentedrelated
Comment #7
chakrapani CreditAttribution: chakrapani commentedRelated issue
Comment #8
chakrapani CreditAttribution: chakrapani commentedThe patch from #2 no longer works. Needs a reroll.
I will work on the re-roll.
Comment #9
chakrapani CreditAttribution: chakrapani commentedMost of the changes required for this are already committed to Head.
Only change required is
But this will be taken care by Replace theme() with drupal_render() in install.core.inc
Hence marking as duplicate and closing.
Comment #10
star-szrReopening, see #2177655-15: Replace theme() with drupal_render() in install.core.inc.
Comment #11
chakrapani CreditAttribution: chakrapani commentedLooking into this.
Comment #12
chakrapani CreditAttribution: chakrapani commentedHere we go. added the following changes to the patch:
Comment #13
LewisNyman CreditAttribution: LewisNyman commentedThis breaks the installer design introduced in #1337554: Develop and use separate branding for the installer.
I'm not really sure how to achieve two designs while removing this theme function.
Also see: #2169765: Redesign update.php to be more consistent with the installation process
Comment #14
chakrapani CreditAttribution: chakrapani commentedAfter LewisNyman's comment and YesCT's suggestion over irc, I have looked into the issue again and noticed the following things:
Related Issues:
https://drupal.org/node/2041793
https://drupal.org/node/2169765
Marking this as won't fix after confirming with YesCT on irc.
Comment #15
star-szrOnce we have #2035055: Introduce hook_theme_prepare[_alter]() and remove hook_preprocess_HOOK() this could potentially be a theme suggestion with a suggestion-specific prepare hook implementation. Postponing for now.
Comment #16
star-szrProof of concept patch that will ultimately be dependent on another issue (to be created). This shows two different methods of examining theme suggestion data in a preprocess function and preprocessing/preparing variables based on that information.
Fresh patch, so no interdiff.
Comment #17
joelpittetPositive this needs a re-roll. Surprised I wasn't following it.
There is now a @todo in the template_preprocess_maintenance_page()
// @todo Rename the templates to page--maintenance + page--install.
This is very much in line with this idea and comes from #2218039: Render the maintenance/install page like any other HTML page
@Cottser how does this merge with your POC?
Comment #18
jamesquinton CreditAttribution: jamesquinton commentedRerolled patch!
Comment #20
jamesquinton CreditAttribution: jamesquinton commentedWill take another look at this later...
Comment #21
star-szrMy POC was #2201781: Pass all theme hook suggestions to theme preprocess functions to allow for suggestion-specific overrides which got shot down pretty quick… so I think we're still waiting on #939462: Specific preprocess functions for theme hook suggestions are not invoked.
Comment #22
joelpittetThis function doesn't exist. Please move the POC over to a follow-up if you think it's worth doing.
Comment #23
Adev22 CreditAttribution: Adev22 at Google Code-In commentedrerolled the patch