Remove theme_install_page()

tag

I don't think Seven should include mobile.install.js on all maintenance pages. I was able to get Seven to only include it on the install pages by using drupal_installation_attempted(), but that function returns FALSE on the "Installation complete" step so mobile.install.js is not included on the last step. Any suggestions appreciated.

#2: 1885714-2.patch queued for re-testing.

RELATED: #1337554: Develop and use separate branding for the installer

related

Related issue

The patch from #2 no longer works. Needs a reroll.
I will work on the re-roll.

Most of the changes required for this are already committed to Head.
Only change required is

+++ b/core/includes/install.core.inc
@@ -872,7 +872,8 @@ function install_display_output($output, $install_state) {
-  print theme('install_page', array('content' => $output));
...
+  print theme('maintenance_page', array('content' => $output));

But this will be taken care by Replace theme() with drupal_render() in install.core.inc
Hence marking as duplicate and closing.

Reopening, see #2177655-15: Replace theme() with drupal_render() in install.core.inc.

Looking into this.

Here we go. added the following changes to the patch:

• removed call to install_page theme and changed them to call maintenance_theme
• removed preprocess_install_page functions
• removed install-page.html.twig files

This breaks the installer design introduced in #1337554: Develop and use separate branding for the installer.

I'm not really sure how to achieve two designs while removing this theme function.

Also see: #2169765: Redesign update.php to be more consistent with the installation process

After LewisNyman's comment and YesCT's suggestion over irc, I have looked into the issue again and noticed the following things:

• The issue summary is outdated and theme_install_page() no longer exists
• install_page no-longer calls the maintenance_page theme.
• install page has a separate template "modules/system/templates/install-page.html.twig" which contains independent html compared to maintenance page.
• install page also has its own install-page.css in the SEVEN theme.

Related Issues:
https://drupal.org/node/2041793
https://drupal.org/node/2169765

Marking this as won't fix after confirming with YesCT on irc.

Once we have #2035055: Introduce hook_theme_prepare[_alter]() and remove hook_preprocess_HOOK() this could potentially be a theme suggestion with a suggestion-specific prepare hook implementation. Postponing for now.

Proof of concept patch that will ultimately be dependent on another issue (to be created). This shows two different methods of examining theme suggestion data in a preprocess function and preprocessing/preparing variables based on that information.

Fresh patch, so no interdiff.

Positive this needs a re-roll. Surprised I wasn't following it.

There is now a @todo in the template_preprocess_maintenance_page()
// @todo Rename the templates to page--maintenance + page--install.

This is very much in line with this idea and comes from #2218039: Render the maintenance/install page like any other HTML page

@Cottser how does this merge with your POC?

Rerolled patch!

Will take another look at this later...

My POC was #2201781: Pass all theme hook suggestions to theme preprocess functions to allow for suggestion-specific overrides which got shot down pretty quick… so I think we're still waiting on #939462: Specific preprocess functions for theme hook suggestions are not invoked.

This function doesn't exist. Please move the POC over to a follow-up if you think it's worth doing.

rerolled the patch