The theme_update_page() function simply calls drupal_add_http_header('Content-Type', 'text/html; charset=utf-8'); and then returns the maintenance page.

Additionally, it is identical to theme_install_page.

Attached patch removes theme function, and relocates functionality.

Related:
#1885714: Remove theme_install_page()

CommentFileSizeAuthor
core-remove_theme_update_page.patch2.93 KBjenlampton

Comments

jenlampton’s picture

jenlampton
she / her
commented
Status: Active » Needs review

status.

thedavidmeister’s picture

thedavidmeister commented
Status: Needs review » Reviewed & tested by the community

Additionally "this function is not themeable" so I think that adds weight to the argument that this theme function should be pulled from the theme system.

I couldn't find any extra calls to theme('update_page') or even just 'update_page', looks like @jenlampton cleaned everything up fine.

This patch is very simple and seems like a "no brainer" to help simplify things a bit so I'm going to mark it RTBC.

Importantly, the update.php page still worked for me and looked fine when it ran the new code instead of theme('maintenance_page');

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

A no brainer indeed... committed b36ca28 pushed to 8.x.

So where's the patch to get rid of theme_install_page? ;)

star-szr’s picture

star-szr
he/him
Primary language English
commented

Woohoo, one less theme function!

@alexpott - the patch for that is at #1885714: Remove theme_install_page() but not ready to go yet, it would cause a regression related to mobile.install.js.

Automatically closed -- issue fixed for 2 weeks with no activity.