Follow up for #1853720: Hide language selection option is backwards

Problem/Motivation

It used to be that by default the hide language checkbox was checked. And when on the content language settings config page, with content translation enabled, when the translatable checkbox was checked, that the hide language checkbox was auto unchecked.
The issue to fix the hide checkbox being backwards must have changed the behavior.
Now, the show language selection checkbox is unchecked by default (ok.) but when translation is enabled, the show language selection checkbox should be toggled to be checked. (Not doing this leads to confusion.)

Proposed resolution

Fix the show language selection checkbox to be enabled when translation is enabled on admin/config/regional/content-language

Remaining tasks

  • look at related issue to find where in the code to fix.
  • create initial patch

User interface changes

show-language-autocheck-2013-01-17_1405.png

API changes

No api changes.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gábor Hojtsy’s picture

Interesting because #1853720: Hide language selection option is backwards did have an update for this. Maybe that got buggy at some point? The code is in entity translation module's JS.

vijaycs85’s picture

Status: Active » Needs review
FileSize
11.66 KB

Do we still have this issue? I just tried with new build and it looks working as expected (refer below):

show-language-auto-check

Gábor Hojtsy’s picture

FileSize
175.56 KB

I cannot reproduce either.

Settings.png

YesCT’s picture

Huh. Could just be me. I'll recheck later to night.

YesCT’s picture

Status: Needs review » Closed (cannot reproduce)

today all looks well. sorry for the worries.