When you currently create a new view the machine name auto-generation does not work, though there are no javascript errors.
machine_name.png

CommentFileSizeAuthor
#7 Screen Shot 2013-01-21 at 7.16.18 AM.png15.02 KBlarowlan
#7 Screen Shot 2013-01-21 at 7.16.27 AM.png13.59 KBlarowlan
#6 interdiff.txt591 bytesdawehner
#6 drupal-1893336-6-tests.patch879 bytesdawehner
#6 drupal-1893336-6.patch1.65 KBdawehner
#4 drupal-1893336-4.patch1.92 KBdawehner
#1 drupal-1893336-1.patch809 bytesdawehner
machine_name.png11.74 KBdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Active » Needs review
FileSize
drupal-1893336-1.patch809 bytes

Here is a fix.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Issue tags: +VDC

Add missing tag

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented

Any way a can add a test for this, I know Javascript doesn't run in the tests but the settings should still be in the dom.
Thoughts?

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
FileSize
drupal-1893336-4.patch1.92 KB

This seems to be one way to test that, sadly the added HTML really doesn't change that much.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Needs review » Needs work

Test at #4 passes btw

+++ b/core/modules/views/lib/Drupal/views/Tests/Wizard/BasicTest.phpundefined
@@ -20,7 +20,7 @@ public static function getInfo() {
+  function _testViewsWizardAndListing() {

Why did this get disabled?

Can we get a test-only patch that demonstrates the fail?

Thanks mate.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs work » Needs review
FileSize
drupal-1893336-6.patch1.65 KB
drupal-1893336-6-tests.patch879 bytes
interdiff.txt591 bytes

You know, these wizard tests failed to often in the paste ;) Thanks for finding that!

Here are all the patches.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Needs review » Reviewed & tested by the community
FileSize
Screen Shot 2013-01-21 at 7.16.27 AM.png13.59 KB
Screen Shot 2013-01-21 at 7.16.18 AM.png15.02 KB

Manually reviewed as well.

Screenshots

Before

Screen Shot 2013-01-21 at 7.16.18 AM.png

After

Screen Shot 2013-01-21 at 7.16.27 AM.png

thanks for accommodating me with the tests.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Title: Machine name javascript does not work » Views Machine name field does not work

More accurate title.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented

Oops, yeah, sorry, that would be my fault, this must have happened in the conversion patch from name to id, got a bit over zealous with the name => id replacement!

That's a good test to add too. All looks good to me!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.