I have not confirmed it yet, but it worths to review it.

Details on #1894882-2: Setting not to let a user vote on his/her own node/comment.

CommentFileSizeAuthor
#2 vote_up_down-acess-denied-ajax-1895594.patch7.6 KBovi.indrei

Comments

marvil07’s picture

marvil07 commented

Ok, confirmed, but not yet solved,

ovi.indrei’s picture

ovi.indrei commented
Assigned: Unassigned » ovi.indrei
Status: Active » Needs review
StatusFileSize
new vote_up_down-acess-denied-ajax-1895594.patch7.6 KB

Here's a patch that transforms access denied errors into more friendly responses when the initial request was made through Ajax. The access check is no longer made at the menu router level, but inside the page callbacks for voting and resetting vote.

ovi.indrei’s picture

ovi.indrei commented

@marvil07, can I please have your thoughts on this one?

antoniocuga’s picture

antoniocuga commented

Hello @ marvil07, @ovidyou .

I just checked the patch and resolve the access denied error, change the message to something more friendly. But i think it is still necessary even refactor the code.

marvil07’s picture

marvil07 commented
Status: Needs review » Needs work

@ovidyou: Thanks for providing a patch. I remember taking a quick look at it, and it seems that the regression happened during the initial porting of the module to D7. So I guess a good suggestion is to see what is done in 6.x-3.x and do the analogous here, that seems to be the idea behind the patch.

@antoniocuga: Thanks for trying the patch. What other steps you think the patch needs to work on? BTW, I'm changing the issue status based on that.