Need to review Sandbox project so that we can apply it for full project application.
http://drupal.org/sandbox/themesplanet/1896370
Thanks

Comments

Gaofengzzz’s picture

Status: Needs review » Needs work

Please provide your project sandbox link and also a valid GIT URL.
Until then, I'm afraid it is going to be very hard to review your application

Please refer to:
Apply for permission to create full projects and in particular:

Fill out the issue form:

  • Component: 'module', 'theme' or 'feature' (depending on the application)
  • Category: task
  • Status: needs review
  • Title: Your project name
  • Description:
    1. A detailed description of what your project does, including how it is different from other, similar projects, if applicable.
    2. For themes it's helpful to include a screenshot.
    3. A link to your project page.
    4. A direct link to your git repository (git clone ...).
    5. Please specify if it's for Drupal 6 and/or 7.
    6. A list of links to reviews of other project applications that you did.

Hope that helps.
Cheers!

eule’s picture

Manual Review

  1. Setup Git
  2. Also mention git repositary path in your issue details.

if this is done, and you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

Good Luck

themesplanet’s picture

Hello,

I have setup my Git, and here is the URL for git repositary path : http://drupalcode.org/sandbox/themesplanet/1896370.git/commit/4237d0e .

Please check it and let me know the next procedure for it.

Thank you.

themestar’s picture

Hi,

Manual review
1) when i go to inner page i m not able to click other menus.
2) main content is overlapping with RHS block
3) breaking inner page structure when i am adding lengthy content.

thanks
themestar

mjohnq3’s picture

I haven't cloned your repository yet but here's a code review from ventral.org:

http://ventral.org/pareview/httpgitdrupalorgsandboxthemesplanet1896370git

Few errors found but it points out that, as mentioned above, you're working from the master branch.

manjit.singh’s picture

1. There would be one info file. So you should remove tp_endurance_responsive_drupal_theme.info file. There is no need of two info. files.

2. Layout of page.tpl.php should not be as per drupal standard. There are some extra un-necessary spaces. please refer some standard structure of tpl files in Drupal7.

page.tpl.php(garland)
page.tpl.php(Seven)

3. Indentation is missing in style.css.

4. Declare CSS file in theme info.

5. It would be great if you add some comments in the starting of regions, Stylesheets, features in info file.
See standard info file here.

mukeysh’s picture

Category: feature » bug

Please put your all template files at one place. In your theme there is a folder named templates where you have 3 files page--front.tpl, node.tpl, html.tpl but your page.tpl is outside the templates folder. Put page.tpl inside the template folder as per standard.

mukeysh’s picture

You directly call the css file in html.tpl under head tag. Which is not the drupal standard. It would be better if you add those files in info file of your theme. If you add css files to your info file then you don't need to call them in head of your html.tpl. e.g
stylesheets[all][] = style.css
Please follow the link for more info http://drupal.org/node/171205

mukeysh’s picture

StatusFileSize
new110.01 KB

In development and navigation block content are not showing. When you hover over it then content are showing. You add the css for .menu a like .menu a { color: #fff}. It reflects to all the menus that have class .menu and 'a' tag. So take some unique parent class for menu. So it will not reflect to another menus.
Please find the attached image below.

mukeysh’s picture

StatusFileSize
new134.06 KB

A bug in admin menu in chrome. Please find the image below.

mukeysh’s picture

StatusFileSize
new102.76 KB

Problem in layout. In front page i enable left sidebar and right sidebar but layout are not showing properly. It shows the main content at left side, left sidebar at the middle and right sidebar is ok. Please find the image below.

Homotechsual’s picture

Assigned: themesplanet » Unassigned
Category: bug » task

Correcting tagging/Issue Fields

bandanasharma’s picture

Follow proper drupal standered for css ( http://drupal.org/node/302199) and romove unwanted commented CSS.
Give the proper name to the classes as you use in tpl file.

bandanasharma’s picture

StatusFileSize
new432.77 KB

Hi,

I have check your theme manually and found some UI bugs in pre login page. Please refer the screenshot for the same.

chris.smith’s picture

StatusFileSize
new31.45 KB
  • Change the 'select' style in css in the bootstrap.css line 1114 from width:220px; to width:100%; so that the comment block is responsive. Before this alteration, the text and 'Text Option' select was going off the page in mobile view.
  • Mobile view navigation link slightly broken: see screenshot.
  • After clicking on the mobile navigation link, the other links on the page are also broken.
  • The mobile navigation button can be fixed by removing the margin-top:32px; on the .toggleMenu class in the bootstrap.css style sheet.
  • .border-bottom class should stretch all the way across the main content div instead of just half.
PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.