On primary navigation menu, class 'active' is not set on active menu item

This should take care of the problem. It worked for me.

Reroll against dev

My bad.

Thanks.

+++ b/includes/menu.inc
@@ -90,7 +90,11 @@ function bootstrap_menu_link(array $variables) {
+ if (($element['#href'] == $_GET['q'] || ($element['#href'] == '<front>' && drupal_is_front_page())) && (empty($element['#localized_options']['language']) || $element['#localized_options']['language']->language == $language_url->language)) {

The $language_url variable (towards the end) is actually not defined in this function. Where is it coming from??

Stumbled upon this when refactoring for 8.x-2.x. Would change the version for this issue, but that branch doesn't have a "release" yet. Tagging for backport.

Yep, it looks like $language_url is a global variable and should be declared as such in bootstrap_menu_link(), am I correct?

Doesn't work with Context menu reaction.

Maybe I do not understand everything, but.. the problem here is to add 'active' when only 'active-trail' is present?

Then why not simply doing it?

  if (array_key_exists('class',$element['#attributes']) 
    && is_array($element['#attributes']['class'])
    && in_array('active-trail',$element['#attributes']['class'])) {
      $element['#attributes']['class'][] = 'active';
  }

Current patch tests the href with q argument, but this will not work for active-trail set via menu_tree_set_path or menu_set_active_trail, as by definition theses things are used to set active trail on things where the path is not an obvious way of finding the active trail.

I'm just moving this back to 7.x. If there needs to be any re-evaluation for 8.x, create a new issue.

+1 for regilero in #11

This patch that went in breaks the use of hook_preprocess_menu_link() to unset the active class on a link on the front page.

Please do not re-open old issues.

Fine. #2618828: Move menu_link "active" class logic into a preprocess function and base it on "active-trail"