The latest vision of colorbox plugin not compatible with drupal Jquery.

There is a call to on function on line 820 of the Plugin which might not work on jqeury older than 1.7

Version tested colorbox plugin 1.3.26

Best Regards
Shameem

Comments

dolly nyc’s picture

dolly nyc CreditAttribution: dolly nyc commented

Per the release notes, update the colorbox plug-in to version 1.3.21 or later (current as of this morning is 1.3.26)
http://www.jacklmoore.com/colorbox

hvalentim’s picture

hvalentim CreditAttribution: hvalentim commented

Well, using 1.3.26 somehow images do not load for me (they stay loading forever).

shameemkm’s picture

shameemkm CreditAttribution: shameemkm commented

Just change on to bind on line number 820 in jqeury.colorbox.js and it should work

on('load' should be changed to bind('load'

dolly nyc’s picture

dolly nyc CreditAttribution: dolly nyc commented

Just to clarify: original post was referring to v 1.3.26 (not 1.3.6)

@shameemkm -- I see you posted on github too. Now the latest version seems to be 1.3.27. Have you tried that version?

hvalentim’s picture

hvalentim CreditAttribution: hvalentim commented

Thanks! That does the trick.
Do you know how to modify the minified version as well? :)

hvalentim’s picture

hvalentim CreditAttribution: hvalentim commented

1.3.27. seems to suffer from the same problem that the unmodified 1.3.26. Just tested.

shameemkm’s picture

shameemkm CreditAttribution: shameemkm commented

I have updated the error report. to show it as 1.3.26. I can still see the on function on the latest version that is 1.3.27 on line number 832 so I suppose it would still give the error. for older versions of jquery which does not support the function.

shameemkm’s picture

shameemkm CreditAttribution: shameemkm commented

@hvalentim you can search for .on("load",function() and change on to bind.

hvalentim’s picture

hvalentim CreditAttribution: hvalentim commented

Yes. If I change line 832 of 1.3.27 (non minified version) to the bellow it will work for me.

.bind('load', function () {

hvalentim’s picture

hvalentim CreditAttribution: hvalentim commented

Thanks again for pointing me in the right direction.

In the minified version that should be in column 8585 of line 7 (v. 1.3.27).

frjo’s picture

frjo CreditAttribution: frjo commented
Category: bug » support
Priority: Major » Normal
Status: Active » Fixed

Seems to be fixed in v1.3.28 of the Colorbox plugin.

https://github.com/jackmoore/colorbox/commit/64a86b97ea27c184dabe3102bfa...

sgriffin’s picture

sgriffin CreditAttribution: sgriffin commented
Status: Fixed » Needs review

There's no errors for 1.3.28 at least, but it doesn't work with JQ 1.7. Images open in self window.

shameemkm’s picture

shameemkm CreditAttribution: shameemkm commented

Got message from color box that the error has been corrected. the Function was supposed to be one and not on it seems to be corrected in the latest update.

Slown’s picture

Slown CreditAttribution: Slown commented

Hi,
for me, there's no errors for 1.3.28 at least, but it doesn't work with jQuery 1.5.2 Images open in self window.

grozozo’s picture

grozozo CreditAttribution: grozozo commented

I will create a new topic since it's not the same issue.

frjo’s picture

frjo CreditAttribution: frjo commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

changed the version number