You're munging my non-Drupal PHP files

Logic issues :)

Hi,

Thanks for the patch.

I'm more than happy to test this. I'll use it for both Drupal and non-Drupal PHP projects for a few days and feedback any issues I find.

Is there anything other than potentially missing Drupal files that you're worried this patch might introduce? Let me know and I'll test those too.

What settings (or other effects) were annoying you when editing non-Drupal files?

I noticed the following issues for PHP files in non-Drupal projects:

• Drupal specific syntax highlighting is used
• Tag List no longer displays any results
• EasyTags can't auto-generate tags as it passes the filetype of "php.drupal" to ctags
• My preferences for tabstops, shiftwidth, textwidth, etc. are overridden

... but, I'm sure that list only scratches the surface. Any functionality that relies on the PHP filetype being correctly set is likely going to suffer.

I am also prevented from manually setting the filetype of a non-Drupal project PHP file back to "php" after it has been set to "php.drupal":

:set filetype
filetype=php.drupal
:set filetype=php
:set filetype
filetype=php.drupal

Hello,

I've been using this patch successfully for 5 days.

I couldn't find any instances of a Drupal file (PHP, JavaScript, Make or Info) within a Drupal 7 project that were ignored.

I had only 1 issue:

If I'm viewing a Drupal file that's outside of a normal Drupal project (e.g. if I've git-cloned a module into a separate directory to browse its source or something), if I attempt to set the filetype to php.drupal I (predictably) get the following:

:set filetype=php.drupal
Error detected while processing /home/users/tom/Projects/tom-vim/vim/bundle/vimrc/bundle/vim-plugin-for-drupal/ftplugin/drupal.vim:
line   18:
E121: Undefined variable: b:Drupal_info
E116: Invalid arguments for function strlen(b:Drupal_info.INFO_FILE)
E15: Invalid expression: strlen(b:Drupal_info.INFO_FILE)
line   21:
E121: Undefined variable: b:Drupal_info
E116: Invalid arguments for function strlen(b:Drupal_info.DRUPAL_ROOT)
E15: Invalid expression: strlen(b:Drupal_info.DRUPAL_ROOT)
line   24:
E121: Undefined variable: b:Drupal_info
E116: Invalid arguments for function strlen(b:Drupal_info.CORE)
E15: Invalid expression: strlen(b:Drupal_info.CORE)
line  148:
E121: Undefined variable: b:Drupal_info
E116: Invalid arguments for function strlen(b:Drupal_info.OPEN_COMMAND)
E15: Invalid expression: strlen(b:Drupal_info.OPEN_COMMAND)

This is because the DrupalInit() function (correctly) can't discover Drupal's version, which results in info.CORE being empty, which then causes the setting of b:Drupal_info to be skipped.

How do you feel about the attached patch? It sets the b:Drupal_info regardless of whether info.CORE has been set. This obviously has the downside of setting b:Drupal_info on all potential Drupal files and will not contain the CORE or DRUPAL_ROOT, which prevents the tags, snippets and function lookup features of your plugin from working... but it does stop the error.

I've added issue #1908966 which suggests adding user defined defaults for the CORE and DRUPAL_ROOT settings.

Thanks for the heads up on TagBar, much prefer it to TagList. :)

Good work Benji.

Have tested all features that I know about in your script. Details are below. To summarise: everything seems to work apart from the lookup functionality (i.e. \da, \dc & \dda)

Appending ".drupal" to PHP & Javascript filetypes:

• Full Drupal project = ok
• Module project = ok
• Module project with multiple info files (e.g. Views) = ok

Setting filetype to "drini.drupal" for info files:

• Full Drupal project = ok
• Module project = ok
• Module project with multiple info files (e.g. Views) = ok

Lookup Drupal Function

\da, \dc & \dda

• Full Drupal project = fail: E117: Unknown function: <SNR>88_OpenURL
• Module project = fail: E117: Unknown function: <SNR>88_OpenURL
• Module project with multiple info files (e.g. Views) = fail: E117: Unknown function: <SNR>88_OpenURL

Tag Lookup

:tag hook_menu

• Full Drupal project = ok
• Module project = ok
• Module project with multiple info files (e.g. Views) = ok

SnipMate snippets

hook_menu<tab>

• Full Drupal project = ok
• Module project = ok
• Module project with multiple info files (e.g. Views) = ok

Just come across another problem which I can only recreate following your patch:

On a full Drupal 7 project which has been created via Drush, when I load a .inc file the following error occurs:

Error detected while processing /home/tom/Projects/tom-vim/vim/bundle/vimrc/bundle/vim-plugin-for-drupal/autoload/drupal.vim:
line   67:
E122: Function drupal#CreateMaps already exists, add ! to replace it
Error detected while processing function drupal#DrupalInfo..drupaldetect#InfoPath:
line   23:
E121: Undefined variable: list
E15: Invalid expression: list[0]
line   24:
E121: Undefined variable: list
E15: Invalid expression: list[0]
line   23:
E121: Undefined variable: list
E15: Invalid expression: list[0]
line   24:
E121: Undefined variable: list
E15: Invalid expression: list[0]

To recreate:

cd somewhere-random
drush dl drupal-7.x
cd drupal-7.x-dev
vim includes/file.inc

However, if I try opening the same file on a Drupal project which has simply been cloned from git, the error does not occur:

git clone -b 7.x --depth 1 git://drupalcode.org/project/drupal.git
cd drupal
vim includes/file.inc

Sorry for the wait, I've not had a dev environment to test your patch until now.

Not sure what was going on, but I can't now recreate the error in #9. Have tried with patch #10, patch #7 and no patch. I was originally able to cause the issue on both my main dev machine and also on a clean vagrant box. So there might still be an issue around, or I was doing something insanely weird.

How interested are you in problem I found in #9? I don't know whether it's pointing towards a fairly serious problem that needs to be investigated further, or was just some crazy fluke.

Can confirm that the /da, /dc and /dda work with the #10 patch.