As discussed here #849926-71: links wrapped in .contextual-links-wrapper divs are not accessible at all via keyboard alone also problems with screen readers - VoiceOver doesn't tell you what block you are editing because the title is not included in the link.
Rather than simply outputting "Open configuration options button", it should "Open configuration options button for Tools block" or "Open configuration options button for Search block".
This will make it easier for people to know they are editing the right block.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | contextual_title-1905340-5.patch | 1.38 KB | wim leers |
| #4 | VoiceOver-ContextConfigEdit.png | 92.54 KB | mgifford |
| #3 | contextual_title-1905340-3.patch | 1.38 KB | plopesc |
| #1 | contextual_title-1905340-1.patch | 1.35 KB | plopesc |
Comments
Comment #1
plopescAttaching patch that adds block id to the contextual message.
Maybe it could take the block title from
<h2>, but this value is not always available.What do you think?
Regards
Comment #2
mgiffordIf you can pull it from the H2 that would be better for sure. The block-search is pronounced and it helps, but there may be some other machine readable names that are just going to cause grief.
It should be a minority of the time that the H2 isn't available. It will be invisible a bunch of the time, but that's fine as far as the code goes.
I don't think there would need to be a fail-over where if the H2 isn't present the machine name is read out.
@plopesc can you roll up the next patch with that change? Thanks!
EDIT: Oh ya, I was testing in Safari with VoiceOver.
Comment #3
plopescHello
Attaching patch taking block name from H2 as you requested.
Regards.
Comment #4
mgiffordAssuming the bot agrees, this works much better with VoiceOver. I'm quite happy that this is pulling the titles for the blocks and providing context! Thanks @plopesc
Comment #5
wim leersMinor improvement to #3, which brings modified
$(selector, $context)to$context.find(selector), in line with other D8 JS :)#4: please double-check that I didn't break anything.
Comment #6
mgiffordTested it again and it's fine. Thanks Wim!
Comment #7
dries commentedCommitted to 8.x. Thanks!
Comment #8
mgiffordThanks @Dries & @plopesc!
I'm just tagging this as I'm realizing only now that it wasn't put in the accessibility group.