Remove module_* deprecated functions

It seems to be helpful to not convert all at once, as this patch has the potential to have to be rerolled A LOT OF times.

#1895266: Convert views to use the ModuleHandler is one of those conversion issues. Catch explained there, that we maybe better wait on #1875086: Improve DX of drupal_container()->get()

First, yes, wait on #1875086: Improve DX of drupal_container()->get() because that issue intends to remove drupal_container() entirely.

Second, I'd then spin up, probably, an issue per module or something like that. Keep the changes localized, so they're easy to parallelize, easy to reroll, and are less fragile. Those are then easily Novice-able tasks, which means we can feed them to Core Office Hours to help onboard people.

That issue is resolved now so let's reopen this for the TC Core Sprint.

If we're breaking it up by function, remove in the same patch. That way we can easily see if we missed a spot because we'll get a fatal function not found error. :-)

I would remove the functions when rolling the patches to help ensure you got everything perfect, but when rolling the final patch for commit, re-add it back in as a wrapper with @deprecated.

As per your suggestion Tim, I have left the deprecated function in the source of my module_exists patch. If the patch can be reviewed and committed, that would be sweet.

Added sub issues.

Updated issue summary.

So, usages are removed, besides a few of module_uninstal(), but those are only in test files
this patch should be enough

Output: [PHP Fatal error: Call to undefined function module_implements() in /opt/drush/includes/bootstrap.inc on line 895

Drush needs to be updated for module_implements(), so lets keep this there for now
Lets see what else

Actually there is already an issue https://github.com/drush-ops/drush/issues/452
Lets postpone it on that

I think i fixed all Drush issues so this can be reopened.

i think we still need the drush version the testbot checks out updated as well..or this happened already, too?

Good question, I have no idea what version the testbot uses. However, I don't think there are any stable 7.x releases so I would guess it uses master. Maybe someone needs to go and do a manual pull.

I'll leave a tell for jthorston, he maintains the test bots.

It uses 7.0.0-alpha1

Well, should we change the branch to master or wait for a release?

Patch in #18 doesn't apply, which is also why the test failed in #24.

$ git apply drupal-remove_module_deprecated-1916134-18.patch 
error: patch failed: core/includes/bootstrap.inc:1118
error: core/includes/bootstrap.inc: patch does not apply
error: patch failed: core/includes/module.inc:152
error: core/includes/module.inc: patch does not apply
error: core/modules/aggregator/src/Tests/AggregatorConfigurationTest.php: No such file or directory
error: patch failed: core/modules/aggregator/src/Tests/UpdateFeedItemTest.php:73
error: core/modules/aggregator/src/Tests/UpdateFeedItemTest.php: patch does not apply
error: patch failed: core/modules/config/src/Tests/ConfigInstallWebTest.php:71
error: core/modules/config/src/Tests/ConfigInstallWebTest.php: patch does not apply
error: core/modules/system/src/Tests/Entity/EntityApiInfoTest.php: No such file or directory
error: patch failed: core/modules/system/src/Tests/Form/LanguageSelectElementTest.php:81
error: core/modules/system/src/Tests/Form/LanguageSelectElementTest.php: patch does not apply
error: patch failed: core/modules/system/src/Tests/Module/ClassLoaderTest.php:50
error: core/modules/system/src/Tests/Module/ClassLoaderTest.php: patch does not apply
error: patch failed: core/modules/system/src/Tests/Module/UninstallTest.php:36
error: core/modules/system/src/Tests/Module/UninstallTest.php: patch does not apply
error: patch failed: core/modules/taxonomy/src/Tests/VocabularyCrudTest.php:196
error: core/modules/taxonomy/src/Tests/VocabularyCrudTest.php: patch does not apply

That's because the functions have been removed in other issues.

Nice. :-)