addFq() expects a dash at the start of the name to trigger a negative filter query, like so: fq[]=-label:Test. When conditions are filtered in validFilterValue(), however, names are only allowed to have letters and numbers, so negative filter queries are removed.

Tiny patch incoming to allow dashes in field names. I'm not sure if allowing dashes in fq names has any negative impact elsewhere though, so please review.

Thanks!

CommentFileSizeAuthor
#2 1918434-2.patch664 bytespwolanin
#1 apachesolr_negative_filter_queries-1918434-1.patch674 byteswintersieck

Comments

wintersieck’s picture

wintersieck commented
StatusFileSize
new apachesolr_negative_filter_queries-1918434-1.patch674 bytes

Patch attached.

pwolanin’s picture

pwolanin commented
StatusFileSize
new 1918434-2.patch664 bytes

If we need to allow a dash at the beginning, that should be done specifically, not allowed anywhere in the field name.

Status: Needs review » Needs work

The last submitted patch, 1918434-2.patch, failed testing.

pwolanin’s picture

pwolanin commented
Status: Needs work » Needs review

#2: 1918434-2.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1918434-2.patch, failed testing.

pwolanin’s picture

pwolanin commented
Version: 7.x-1.x-dev » 6.x-3.x-dev
Status: Needs work » Patch (to be ported)

oops - seems that was committed as part of commit:

commit cdf1e9722d8dece450077b454aea975d2dcf8d54
Author: pwolanin
Date: Mon Jun 10 16:16:23 2013 -0400

Issue #1861572 by fizk: api docs typo fix

pwolanin’s picture

pwolanin commented
Status: Patch (to be ported) » Fixed

patch applies - committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.