Base module and submodules (Drupal 6 for now).

The name, SCAR, could stand for System Control &/by Access Rules, or as an acronym for System Access Control Rules, or... actually, after having spent over 4 days cooking my brains, searching for a good module name that would reflect what the module does, and seen that every good candidate name was already taken:

AR for Access Rules taken as AR for Arabian;
ACK for Access Control Kit (drupal 7);
ACL for Access Control Lists;
and so on...

I was just too tired to keep looking. So, this is it.

After reading that, you probably have a notion of what it is for. The idea was to be able to administer (grant/deny) access across the whole system, but in a more private and flexible way than usual.

So, this module is intended to define/identify administrator/s, who will have an extra category (besides typical roles), and will be able to login as SCAR admins. Then, the idea is to write more specific sub modules (6 so far) in order to administer (grant/deny) more specific access by defining according specific access rules.

Project page: http://drupal.org/sandbox/scarafia/1915904

Git repository: git clone --recursive --branch 6.x-1.x http://git.drupal.org/sandbox/scarafia/1915904.git scar

Drupal 6 for now

Comments

npscode’s picture

npscode commented

Hi scarafia,

Comments after a manual review :

Your .info files contains release info, version etc that automatically gets added by the packaging script on drupal.org (the version/info/timestamp info). These lines should be removed from your .info file. Have a look at an established contrib module's info file, you'll see which lines automatically get added.

I also ran your module through PAReview, which lists all the code style issues, and a few other ones, see http://ventral.org/pareview/httpgitdrupalorgsandboxscarafia1915904git for the report. You can re-run the review after you've made changes, to verify your progress.

Dont use require_once() to include files, you can use module_load_include instead. refer http://api.drupal.org/api/drupal/includes!module.inc/function/module_loa....

Dont use drupal_add_js() in tpl file. you should include all the javascript in your module file itself.

npscode’s picture

npscode commented
Status: Needs review » Needs work

Oops, forgot to change status..

scarafia’s picture

scarafia commented
Status: Needs work » Needs review

Hi, first of all excuse me if I did wrong by changing the state to "needs review"... was it wrong?

I actually wanted to make a question about the "Use XHTML style tags instead of" errors. I don't understand what that means (I googled it). Would you please point me any direction?

As you can see, between http://ventral.org/pareview/httpgitdrupalorgsandboxscarafia1915904git and http://ventral.org/node/230132/revisions/240538/view, I've done my homework. Besides that error, there are only a few warnings left.

About those, it's the same warning repeated several times: I use "// =============" as separators in my code; do I MUST to remove them?

Thanks in advance.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

Homotechsual’s picture

Homotechsual commented

About those, it's the same warning repeated several times: I use "// =============" as separators in my code; do I MUST to remove them?

Yes you must remove those. The spacing/sectioning of code is covered in the Drupal coding/doxygen comment standards for Drupal.

Drupal Coding Standards
Drupal Doxygen/Comment Standards

You should set the issue to 'needs review' when you have fixed the issues raised in prior reviews. The issue will then be set to 'needs work' by the next reviewer to find issues.

Hope this helps!

ankitchauhan’s picture

ankitchauhan commented
Status: Needs review » Needs work

changing status to needs work

PA robot’s picture

PA robot commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.