http://drupal.org/node/1907900 added hardcoded credits in page.tpl.php, which is against the guidelines regarding advertising as described at http://drupal.org/node/439226. They should be removed or made admin-configurable so people who do want to use the theme for their website can turn the credits off.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

gtsopour’s picture

Assigned: Unassigned » gtsopour
clivesj’s picture

Status: Active » Needs review
FileSize
2.79 KB
9.11 KB

With this patch the credits in the footer are made configurable.
On the settings page it can be toggled on/off. See attached image.

clivesj’s picture

Priority: Normal » Critical

This theme does not comply with regulations set by Drupal.
Please apply this patch to bring it back within bounds!

bradezone’s picture

Issue summary: View changes

Was this patch never applied to the project officially? How can that footer advertisement still be hard-coded into the theme? PLEASE update this.

gtsopour’s picture

Category: Bug report » Feature request
Status: Needs review » Patch (to be ported)

Hello and sorry for the late response,
I will review/commit this patch. Next Corporate Clean release will contain this option.

Best
George

bradezone’s picture

Excellent.

bradezone’s picture

Any ETA on this? I'm looking to launch a client site in May and would love to have this update. Thanks.

wiltech3947’s picture

I'm new to this, how would i install it

dddave’s picture

@#8 https://drupal.org/node/620014 and surrounding docs

@gtsopour: Could you please AT LEAST create a new dev version containing this change? The original issue warrants a much quicker implementation.

dddave’s picture

wiltech3947’s picture

Okay am I not right in the fact that "make-credits-configurable-issue-1919098.patch" is a patch for this issue.
I would be happy just to learn how to install or overwrite where its needed. If you could please show me how or where that would be great.
plus I would learn something new.
ps. if there is a place that tells me how to do this already could you please point it out.

clivesj’s picture

FileSize
938.22 KB

As this is taking so long now i will post a zip file containing the patched version of the theme.
For those who are waiting for the patched version and cannot patch themselves.
Unzip the file and replace the current theme with the one supplied here.

Don't get me wrong. I 'm really happy and grateful to have this theme. But this shouldn't take this long!

gtsopour’s picture

Title: remove hardcoded credits or make them admin-configurable » Make hardcoded credits (page.tpl.php) admin-configurable
Status: Patch (to be ported) » Fixed

Hello and I am really sorry for the late response. I just committed all the changes regarding this feature request https://drupal.org/commitlog/commit/24910/f96361ea97a1fb939e186cea376af4...

Made changes to
corporateclean: /corporateclean.info
corporateclean: /page.tpl.php
corporateclean: /theme-settings.php

In the next two days, we will release the next Corporate Clean 7.x-2.2 with this change and some extra bug fixes/changes.

Thanks again for all
George

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

bradezone’s picture

Looking forward to the actual release of the next version ;]

dddave’s picture

Version: 7.x-2.1 » 7.x-2.2
Status: Closed (fixed) » Needs work

There is still neither an new full release NOR a dev release containing the fix. PLEASE!

naveenvalecha’s picture

The above#2 patch needs some white space fixes and after checking its committed. http://cgit.drupalcode.org/corporateclean/commit/?id=f96361e

Thanks
Naveen Valecha

gtsopour’s picture

Status: Needs work » Fixed

Hello and sorry again for the late response,
Corporate Clean 7.x-2.3 https://www.drupal.org/node/2327793 makes the hardcoded credits (page.tpl.php) admin-configurable.

Best
George

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.