Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
http://drupal.org/node/1907900 added hardcoded credits in page.tpl.php, which is against the guidelines regarding advertising as described at http://drupal.org/node/439226. They should be removed or made admin-configurable so people who do want to use the theme for their website can turn the credits off.
Comment | File | Size | Author |
---|---|---|---|
#12 | corporateclean_patched.zip | 938.22 KB | clivesj |
#2 | issue.1919098.png | 9.11 KB | clivesj |
#2 | make-credits-configurable-issue-1919098.patch | 2.79 KB | clivesj |
Comments
Comment #1
gtsopour CreditAttribution: gtsopour commentedComment #2
clivesj CreditAttribution: clivesj commentedWith this patch the credits in the footer are made configurable.
On the settings page it can be toggled on/off. See attached image.
Comment #3
clivesj CreditAttribution: clivesj commentedThis theme does not comply with regulations set by Drupal.
Please apply this patch to bring it back within bounds!
Comment #4
bradezone CreditAttribution: bradezone commentedWas this patch never applied to the project officially? How can that footer advertisement still be hard-coded into the theme? PLEASE update this.
Comment #5
gtsopour CreditAttribution: gtsopour commentedHello and sorry for the late response,
I will review/commit this patch. Next Corporate Clean release will contain this option.
Best
George
Comment #6
bradezone CreditAttribution: bradezone commentedExcellent.
Comment #7
bradezone CreditAttribution: bradezone commentedAny ETA on this? I'm looking to launch a client site in May and would love to have this update. Thanks.
Comment #8
wiltech3947 CreditAttribution: wiltech3947 commentedI'm new to this, how would i install it
Comment #9
dddave CreditAttribution: dddave commented@#8 https://drupal.org/node/620014 and surrounding docs
@gtsopour: Could you please AT LEAST create a new dev version containing this change? The original issue warrants a much quicker implementation.
Comment #10
dddave CreditAttribution: dddave commentedComment #11
wiltech3947 CreditAttribution: wiltech3947 commentedOkay am I not right in the fact that "make-credits-configurable-issue-1919098.patch" is a patch for this issue.
I would be happy just to learn how to install or overwrite where its needed. If you could please show me how or where that would be great.
plus I would learn something new.
ps. if there is a place that tells me how to do this already could you please point it out.
Comment #12
clivesj CreditAttribution: clivesj commentedAs this is taking so long now i will post a zip file containing the patched version of the theme.
For those who are waiting for the patched version and cannot patch themselves.
Unzip the file and replace the current theme with the one supplied here.
Don't get me wrong. I 'm really happy and grateful to have this theme. But this shouldn't take this long!
Comment #13
gtsopour CreditAttribution: gtsopour commentedHello and I am really sorry for the late response. I just committed all the changes regarding this feature request https://drupal.org/commitlog/commit/24910/f96361ea97a1fb939e186cea376af4...
Made changes to
corporateclean: /corporateclean.info
corporateclean: /page.tpl.php
corporateclean: /theme-settings.php
In the next two days, we will release the next Corporate Clean 7.x-2.2 with this change and some extra bug fixes/changes.
Thanks again for all
George
Comment #15
bradezone CreditAttribution: bradezone commentedLooking forward to the actual release of the next version ;]
Comment #16
dddave CreditAttribution: dddave commentedThere is still neither an new full release NOR a dev release containing the fix. PLEASE!
Comment #17
naveenvalechaThe above#2 patch needs some white space fixes and after checking its committed. http://cgit.drupalcode.org/corporateclean/commit/?id=f96361e
Thanks
Naveen Valecha
Comment #18
gtsopour CreditAttribution: gtsopour commentedHello and sorry again for the late response,
Corporate Clean 7.x-2.3 https://www.drupal.org/node/2327793 makes the hardcoded credits (page.tpl.php) admin-configurable.
Best
George