In a project I missed the ability to act on changes to panelizer defaults.

I added a patch for acting when panelizer defaults get deleted.

Of course hooks for other events is also be desirable.

At least this is a starting point to see if the idea is usable for someone else.

Please notice the patch is for 7.x-2.x-dev (because that is the version I'm currently working with). The patch also applies to the 7.x-3.x-dev branch (with minor offsets).

CommentFileSizeAuthor
#7 panelizer-n1929000-7.patch1.73 KBDamienMcKenna
#5 provide_hooks_on-1929000-5.patch1.63 KBmglaman
#2 panelizer-provide_hooks_on_panelizer_defaults-1929000-2.patch2.02 KBarnested
#1 panelizer-provide_hooks_on_panelizer_defaults-1929000-1.patch2.19 KBarnested
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

arnested’s picture

arnested CreditAttribution: arnested commented
Status: Active » Needs review
FileSize
panelizer-provide_hooks_on_panelizer_defaults-1929000-1.patch2.19 KB
arnested’s picture

arnested CreditAttribution: arnested commented
FileSize
panelizer-provide_hooks_on_panelizer_defaults-1929000-2.patch2.02 KB

I just realized the two functions panelizer_default_settings_page() and panelizer_export_export_callback() where not having the same functionality and couldn't be merged.

Improved patch.

arnested’s picture

arnested CreditAttribution: arnested commented
Issue summary: View changes

Updated issue summary. Fixed spelling.

arnested’s picture

arnested CreditAttribution: arnested commented
Issue summary: View changes
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Version: 7.x-2.x-dev » 7.x-3.x-dev
Status: Needs review » Needs work

This needs some updates & fixes:

  • It needs to be rerolled for v3 (v2 is no longer supported), especially the API docs as there's now a panelizer.api.php file.
  • The change to panelizer_export_delete_callback() needs to be fixed as there is no $panelizer variable in it.
mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman commented
Status: Needs work » Needs review
FileSize
provide_hooks_on-1929000-5.patch1.63 KB

Re-roll against 3.x, fixes the export object module invoke call.

jeffdiecks queued 5: provide_hooks_on-1929000-5.patch for re-testing.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
FileSize
panelizer-n1929000-7.patch1.73 KB

Minor tweaks to the comments.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Needs review » Fixed

Committed. Thank you both.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Issue tags: +SprintWeekend2015

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.