DBinfo report

As this module seems to aim on developers, I would add the dev package to the info file. (package = Development)

ok. good idea thanks.

As the password is always omitted in your report, I would remove it from the UI, as it has no benefit for the viewing user.

The report is showing essentially all the config info passed to $db = new PDO(<config info>);. Showing that you supplied a valid password to PDO is important if the connection doesnt work, you clearly had a key (its in the report as omitted) vs not supplying a key. This will help to correlate any MySQL error message shown in a connection test.

Please make the configuration keys translateable, so different languages show the translated name. (e.g. "Treiber" (DE) instead of "driver" (EN))

I'm sorry what? PHP.ini and Drupals settings.php are essentially in English (please correct me if I'm wrong). By providing translated keys you now cannot grep settings.php for a given key shown on the page (translated). I dont see the benefit to showing misleading information.

There are empty rule declarations in the css (css/dbinfo.css) and a image url which should be written as "/misc/message-16-error.png" instead of "/modules/system/../../misc/message-16-error.png".

Oops your right, I'll clean up the css.

Updated code to amend 2 issues comment #2.

I'm currently not translating db config keys because they array keys are not translatable. You cannot write PHP code for FAPI such as:

// This is spanish and english.
$form['sample_field'] = array(
  'tipo' => 'select',
  'selectiones' => array(0 => t('yes'), 1 => t('no'),),
  'eleccion_por_defecto' => 'yes',
);

Array keys are array keys and not translatable strings. Drupal FAPI would choke on the above, and it's meaningless.

I am leaving the password as omitted. Would people like asterisks instead of omitted if a password is provided?

I have re-tested against Parview:

FILE: /var/www/drupal-7-pareview/pareview_temp/dbinfo/dbinfo.install
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
171 | ERROR | Use XHTML style tags instead of
--------------------------------------------------------------------------------

I have an html 5 compatible <br> tag .... as I feel HTML 5 is the way to go, I have no love for XHTML.

Instead of "omitted", would a Yes/No make more sense?

A fellow module maintainer whom I showed the project to offlist recommended the string text [omitted] as the password so that the password appears similar to a token text description and developers would better understand it was a replaced value not being shown.

I was debating asterisks exactly strelen($password) long as a second option.

Of course you are right, translating the keys in the array doesn't make sense and was not my intention. I thought about translating the output of your report. So instead of outputting the $key and it's value (driver: mysql), you could pass $key to t(), so "t($key): $value" would become "driver: mysql" and (if translations exist) "Treiber: mysql" in german. But I'm fine with your current implementation, this was just a suggestion for a "more translated" report :)

Ah, I see what you're saying I think ... hmm ... for now I'll leave it as-is. The report(s) table headers, and the status row title are translatable. Thanks for the input.

added review of 1 project dx_cache

reviewed github_pages module

reviewed 3 modules in needs review listing.

Changes

• refactored non-hook functions to own file.
• added configuration page
• changed omitted string for password

committed fixes requested by klausi.