Environmental administration menu

Needs review.

I put the clone command up in the description and fixed all pareview code style errors.
http://ventral.org/node/183240/revisions/view/253621/254537

@vlad.pavlovic

1. I fixed the warning on the foreach() by checking if the environment variable is not empty.
2. I was just thinking about using a theming function for the coloring form, not actually using it. So that has been deleted.
3. I've wrapped the 3 occurrences of the same code into one function for re-use.
   

   /**
    * Helper function to return the current user account.
    */
   function admin_menu_environmental_get_current_user_account() {
     global $user;
     $account = $user;
     if (isset($_SESSION['masquerading'])) {
       $account = user_load($_SESSION['masquerading']);
     }
     return $account;
   }
   

4. For the configuration form:
   This was indeed a bit unusual, but I wanted the user to be able to change any variable without reloading the page. Instead of using a weird logic for the #required property I'm now handling the validation myself. It will only pass validation if all three fields are filled out. And to inform the user about this I've set a little help text above the table.

@Anks

1. In this case I don't think I have to go through check_plain() because the variables are all hardcoded in the array above:

     $fields = array(
       'bar_dark' => t('Bar dark'),
       'bar_light' => t('Bar light'),
       'bar_hover' => t('Bar hover'),
       'bar_active' => t('Bar active'),
       'dropdown_empty' => t('Dropdown empty'),
       'dropdown_container' => t('Dropdown container'),
       'dropdown_hover' => t('Dropdown hover'),
       'dropdown_border' => t('Dropdown border'),
     );
     // Build the color fields.
     foreach ($fields as $field_key => $field_title) {
       $form['colors']['admin_menu_environmental_colors'][$color][$field_key] = array(
         '#type' => $fieldtype,
         '#title' => $field_title,
         '#title_display' => $label_visibility,
         '#default_value' => isset($admin_menu_environmental_colors[$color][$field_key]) ? $admin_menu_environmental_colors[$color][$field_key] : '',
         '#size' => 7,
         '#field_prefix' => $field_prefix,
       );
     }
   
   

   Same goes for the new validation function where I use placeholders for !title and !number. These are also hardcoded, so no danger for XSS right?

2. I've added the @file blocks to the rest of the files

@OPIN

1. The icons was a thing I started, but don't really have time to complete. Maybe when this gets to full project state I will have another go at that. So for now I removed any references to the icons.
2. On the administration configuration error I would like a little bit more feedback about how to replicate. I'm not able to... Maybe you are running admin_menu_environmental with the full realease of admin_menu instead of the dev version. If thats the cause for this error I will add a version requirement to my info file.